Closed Bug 336521 Opened 19 years ago Closed 19 years ago

init.sh adds /bin and /usr/bin before ${DIST}/${OBJDIR}/bin to PATH

Categories

(NSS :: Test, defect)

3.11
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
3.11.2

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

1.37 KB, patch
slavomir.katuscak+mozilla
: review+
Details | Diff | Splinter Review
The script tests/common/init.sh sets the PATH environment variable so that the command-line tools such as certutil under ${DIST}/${OBJDIR}/bin can be found. However, it adds the system directories /bin and /usr/bin before ${DIST}/${OBJDIR}/bin to PATH. So, if your system has a certutil installed in /usr/bin, our test scripts will use that certutil instead of the one in the build tree.
Attached patch Proposed patchSplinter Review
As the comment explains, the purpose of having /bin and /usr/bin at the beginning of PATH is to ensure that a local perl (as opposed to a perl installed in a network-mounted directory) is used. Since we do not have any program named perl in our build tree, it is safe to move ${DIST)/${OBJDIR}/bin and ${DIST}/${OBJDIR}/lib before /bin and /usr/bin in PATH.
Attachment #220716 - Flags: review?(slavomir.katuscak)
Attachment #220716 - Flags: review?(slavomir.katuscak) → review+
I checked in the patch on the NSS trunk (3.12) and NSS_3_11_BRANCH (3.11.2).
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.11.2
Assignee: nobody → wtchang
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: