9.35 KB, image/png
6.42 KB, image/png
15.34 KB, image/png
4.54 KB, patch
|Details | Diff | Splinter Review|
The search-engine popup should show up as wide as the searchbox, right-justified with the box, with the engine icons aligned under the icon that shows in the box.
That is going to look weird if the searchbox is very wide. And since it's finally going to be resizeable, many people may be inclined to make it a lot wider than normally. They would get a big drop-down with all the text on the far left and a cursor on the right, over empty space .
Whiteboard: [swag: 2d] → [swag: 2d] after blocking bug gets fixed
Created attachment 226889 [details] [diff] [review] Moves and widens drop-down menu This change raises a couple of UI issues: The menu tries to match the searchbar's width, but when that's very narrow, the menu becomes useless, so it has a minimum width. This looks a little odd (but shouldn't come up often); see the screenshot. Another possibility would be to flip the menu over to the right side when it shrinks past some (larger) minimum size, but I'm concerned that that would be more disconcerting. On Mac, where menu fonts are larger, even a reasonable-sized searchbar makes the menu narrow enough to cut off the "Manage Search Engines" text. Is there a good way to shorten that string so it fits? And what does that mean for l10n? The icons don't line up perfectly, especially on the Mac. I'm sure I could get them to. I'm also sure it would be a half day of fiddling. And I kind of like it this way -- it looks like it's popping out of the searchbar. But if it's important to line them up, say the word and I'll do it.
Attachment #226889 - Flags: ui-review?(beltzner)
Whiteboard: [swag: 2d] after blocking bug gets fixed → [swag: 1d]
moving out, there's some redesign work that changes this that'll hit b2
Target Milestone: Firefox 2 beta1 → Firefox 2 beta2
Whiteboard: [swag: 1d] → [depends on binding changes for new theme work][mustfix]
Comment on attachment 226889 [details] [diff] [review] Moves and widens drop-down menu I think this applies even with the new theme work. cc'ing the RC guys just in case.
Attachment #226889 - Flags: ui-review?(beltzner) → ui-review+
It does affect it, but the Search Provider control has moved back to the left now so it's less of an impact. Still worth noting.
Clearly we don't want to flip the menu to the left anymore. What do we want to do about the width? Matching it to the searchbar, as this patch does, leads to weirdness when the searchbar gets very small -- and means the "Manage Search Engines" text doesn't fit even at reasonable sizes on a Mac. For those reasons, I'm inclined to skip it, since it doesn't look as funny with a mismatched width now thta it's attached at the left (cf. the back and forward buttons).
We need to QA this change in localized builds. The truncation of "Manage Search Engines..." may cut off the "Manage" in some locales, which may be confusing. I'd welcome a post in .l10n to find out which locales would most likely be affected, i.e., have the "manage" part at the end.
It's not clear to me that this change is still needed. (See my comment #10.) I'd be inclined to WONTFIX this bug, but it's waiting for a final decision.
I think I'm with Pam on this one...
Yes, WONTFIX Is the answer here now. Good call.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.