336577 - handle bogus TZID quoting?

Status: RESOLVED DUPLICATE of bug 357252

(Calendar :: Internal Components, enhancement)

Description

[Blair Sutton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3 XPCOMViewer/0.8.1.2
Build Identifier: Lightning nightly (build 2006050307)

When importing a ics file that contains VEVENT and RECURRENCE-ID with TZID. Lightning and Sunbird throw an exception: -

Unable to read from file:<filename>
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [calIIcalComponent.recurrenceId]"

etc...

Reproducible: Always

Steps to Reproduce:
1. Attempt to import provided ICS file (i.e. Lightning, choose "Calendar/Import..."


Actual Results:  
Exception dialog appears then a prompt for destination calendar. Data not imported.

Expected Results:  
No exception dialog. Prompt for destination calendar. Data should be imported.

By editing the ICS file and changing a line that looks like this: -

RECURRENCE-ID;TZID="Greenwich Mean Time : Dublin, Edinburgh, Lisbon, London":20060517T000000

to this: -

RECURRENCE-ID:20060517T000000

stops the exception from happening.

Comment 1

[Blair Sutton]

Attachment: test case that shows bug

Comment 2

[Joey Minta]

Of course this testcase fails because you haven't defined the timezone that you're using as a TZID.  A VTIMEZONE component is required to identify/define any uses of TZID.  Can you try making those changes and see if it helps?

Comment 3

[Blair Sutton]

Attachment: Updated sample file that demonstrates bug.

Comment 4

[Blair Sutton]

(In reply to comment #2)
> Of course this testcase fails because you haven't defined the timezone that
> you're using as a TZID.  A VTIMEZONE component is required to identify/define
> any uses of TZID.  Can you try making those changes and see if it helps?
> 

Okay I thought by stripping the file down to a core VEVENT it would help you trace the bug. Here I attach the full file anonymized with the TIMEZONE component still in place. This file was produced by Outlook.

Comment 5

[Joey Minta]

(In reply to comment #3)
> Created an attachment (id=220931) [edit]
> Updated sample file that demonstrates bug.
> 
BEGIN:VTIMEZONE
TZID:Greenwich Mean Time : Dublin, Edinburgh, Lisbon, London
...
DTSTART;TZID="Greenwich Mean Time : Dublin, Edinburgh, Lisbon, London":20060505T090000
This is still a faulty ics file.  Placing the timezone in quotes in one place, but not in another is not allowed.  If I add quotes to the first TZID, everything works fine for me and I can import the file without a problem.

Comment 6

[Blair Sutton]

You are right, from reading RFC2445, Section 4.1.1: -

   Property parameters with values containing a COLON, a SEMICOLON or a
   COMMA character MUST be placed in quoted text.

Still, it might take a while to get MS to fix their buggy implementation. Is there a workaround for Lightning or Sunbird?

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!

Comment 8

[cmtalbert]

*** Bug 353387 has been marked as a duplicate of this bug. ***

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

This should actually already have been fixed in bug 357252.

*** This bug has been marked as a duplicate of 357252 ***