336607 - XEmbed not detected by gnash plugin

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[David Woodhouse]

User-Agent:       Mozilla/5.0 (X11; U; Linux ppc64; en-US; rv:1.8.0.2) Gecko/20060419 Fedora/1.5.0.2-1.2.fc5 Firefox/1.5.0.2 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux ppc64; en-US; rv:1.8.0.2) Gecko/20060419 Fedora/1.5.0.2-1.2.fc5 Firefox/1.5.0.2 pango-text

The sample code at
http://www.mozilla.org/projects/plugins/xembed-plugin-extension.html suggests
that you should use this code to detect XEmbed...

    PRBool supportsXEmbed = PR_FALSE;

    err = CallNPN_GetValueProc(gNetscapeFuncs.getvalue, NULL,
                               NPNVSupportsXEmbedBool,
                               (void *)&supportsXEmbed);

    if (err != NPERR_NO_ERROR || supportsXEmbed != PR_TRUE)
        return NPERR_INCOMPATIBLE_VERSION_ERROR;

This doesn't seem to work though. PRBool seems to be an int -- its size is 4
bytes. The CallNPN_GetValueProc() call sets only the first byte and leaves the
others untouched. So on a big-endian machine, supportsXEmbed gets set to
0x01000000, which != PR_TRUE.

Is this a bug in the documentation, or in firefox?

Reproducible: Always

Steps to Reproduce:
1. Build gnash (http://www.gnu.org/software/gnash/)
2. Hack your firefox startup script so you actually see messages to stderr
3. See it say "WARNING: No xEmbed support in this Mozilla version!"

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Well, the value output should really be PR_TRUE or PR_FALSE.  However, if you are casting a PRBool to a void*, you should make sure it's a PRBool that is returned.    I'd say that this should be fixed to not compare against PR_TRUE directly, since it is bad practice in general especially for things such as this.  Comparing against PR_FALSE might be better, but really, just do 

    if (err != NPERR_NO_ERROR || !supportsXEmbed)

Comment 2

[Tyler Downer [He/Him]]

This bug was originally reported on Firefox 2.x or older, which is no longer supported and will not be receiving any more updates. I strongly suggest that you update to Firefox 3.6.6 or later, update your plugins (flash, adobe, etc.), and retest in a new profile. If you still see the issue with the updated Firefox, please post here. Otherwise, please close as RESOLVED > WORKSFORME
http://www.mozilla.com
http://support.mozilla.com/kb/Managing+profiles
http://support.mozilla.com/kb/Safe+mode

Comment 3

[Tyler Downer [He/Him]]

No reply, INCOMPLETE. Please retest with Firefox 3.6.8 or later and a new profile (http://support.mozilla.com/kb/Managing+profiles). If you continue to see this issue with the newest firefox and a new profile, then please comment on this bug.