33663 - PLS move bookmarks.html and panels.rdf to chrome/.../locale

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[tao]

These content of htese two files will be different per localized build.
AS of now, they reside in bin/defaults/profile/ as opposed to 
chrome/[package]/locale/en-US.

Unless there is strong reason to keep them in the default directory, 
please move them to the appropriate locale directories under chrome


Thanks.

Comment 1

[tao]

Hi, folks:


Unless there is an objection, please resolve this bug in M16 so we can get our
beta2 radar clear and focus on other tasks.


Thanks.

Comment 2

[tao]

These bugs are prerequisites of our beta2 localization plan. Add "beta2" 
to keyword.

Comment 3

[leger]

Putting on [nsbeta2+] radar for beta2 fix.

Comment 4

[don]

M17.

Comment 5

[Steve Lamm]

Attachment: Changes needed for panels.rdf

Comment 6

[Steve Lamm]

Tao, would you review my changes for panels.rdf?

Comment 7

[tao]

Sorry that the late reply. I won't be checking mails as often until next May 22 
or 23, 2000.

Your patch looks good. However, there is a concern that once we move to ship
langpack as jar files, we might not be able to copy those default files
(panels.rdf, search.rdf, and bookmarks.html) from within jar file. If you
don't see this as a concern, please go ahead to check in those file (w/ ifdef?).

Otherwise, hold those patches for a while. The final solution might be
have path name like bin/defaults/profile/ja-JP/panels.rdf and fallback to
bin/defaults/profile/panels.rdf when the former doesn't exist. The pro of
this approach is that it applies to all fils under defaults instead of 
fixing those files one by one... (dveditz knew what my plan is if you'd 
like to know the details.)

It's your call... I'll get back to you as soon as I back to the office
earlier next week.


Thanks again for providing the patch. 

Comment 8

[don]

Move to M18 target milestone.

Comment 9

[tao]

Hi, Steve:

Would you reassign this bug to me? I have come up w/ a patch that will first 
look for bin/defaults/profile/{locale name}/* and then bin/defaults/profile/*
in copying the default files for a new profile. This solution will solve the
localizability of all files, including seach.rdf, under bin/defaults/profile.

I'll ask for code review once it is ready.


Thanks

Comment 10

[Steve Lamm]

That sounds better than my changes.
-->tao

Comment 11

[tao]

mark it m16.

Comment 12

[tao]

checked in.

Comment 13

[Claudius Gayle]

tao, could you please tell me the fully qualified path name for where these two files
(bookmarks.html and panels.rdf) should reside under the new system before I verify this?

Comment 14

[tao]

Hi,

For US release there should be

  bin/defaults/profile/{search.rdf, panles.rdf, bookmarks.html}
  bin/defaults/profile/en-US/{search.rdf, panles.rdf, bookmarks.html}


These files affect default setting of sherlock search engines, Sidebar panel,
and Bookmarks files of a new profile.


Let me know if you need assistance verifying the bug. thx!

Comment 15

[Claudius Gayle]

marking VERIFIED