Closed Bug 336634 Opened 18 years ago Closed 18 years ago

command+w on active tab closes browser window

Categories

(Camino Graveyard :: Tabbed Browsing, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: adamleebartlett, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.3) Gecko/20060427 Camino/1.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.3) Gecko/20060427 Camino/1.0.1

occasionally when multiple tabs are open, and i press command+w to close an active one, the entire browser window will close

Reproducible: Sometimes

Steps to Reproduce:
1. open 5-10 tabs within same window
2. select second tab
3. press command+w

Actual Results:  
sometimes, entire window will close when there are multiple tabs still open... 35% of the time?

Expected Results:  
closed one tab at a time
Check your Console.log to see if there's a crash report being written. You should, at minimum, be seeing a dialog asking if you really want to close the window with X number of tabs in it. This sounds like crashing, not quitting/closing.

cl
(In reply to comment #1)
> Check your Console.log to see if there's a crash report being written. You
> should, at minimum, be seeing a dialog asking if you really want to close the
> window with X number of tabs in it. This sounds like crashing, not
> quitting/closing.
> 
> cl
> 

the application does not crash or quit, the window simply closes. the app. is still running.
-a
Tweaking summary per comment 2.

Is there any message at all in the console log when this happens?

cl
Summary: command+w on active tab closes entire browser → command+w on active tab closes browser window
Just to cover even the obvious possibilities--are you sure you aren't accidentally holding shift?
Hello folks,

I am Adam's sysadmin at work (where he is getting this bug).  He left me an email yesterday saying it happened to him again around 4:50PM, so I took a look at his logs.  I don't see anything that looks obviously related, but he does have a _lot_ of the following errors (I assume he gets one everytime he prints):

2006-05-04 16:35:23.739 Camino[367] CFLog (0):
2006-05-04 16:35:24.241 Camino[367] CFLog (21): Error loading
/Library/Printers/hp/Frameworks/HPImaging.framework/Versions/A/HPImaging: 
error code 0, error number 2 (dyld:
/Applications/Camino.app/Contents/MacOS/Camino can't open library:
/Library/Printers/hp/Frameworks/HPImaging.framework/Versions/A/HPImaging 
(No such file or directory, errno = 2)
2006-05-04 16:35:24.256 Camino[367] CFLog (22): Cannot find function
pointer PluginFactoryFunction for factory
1174DEAA-495B-11D5-83E5-000A27E3C238 in CFBundle/CFPlugIn 0x79aa480
</Library/Printers/PPD Plugins/HPColorQuality.plugin> (bundle, not loaded)
2006-05-04 16:42:25.448 Camino[367] CFLog (0):
2006-05-04 16:42:25.839 Camino[367] CFLog (21): Error loading
/Library/Printers/hp/Frameworks/HPImaging.framework/Versions/A/HPImaging: 
error code 0, error number 2 (dyld:
/Applications/Camino.app/Contents/MacOS/Camino can't open library:
/Library/Printers/hp/Frameworks/HPImaging.framework/Versions/A/HPImaging 
(No such file or directory, errno = 2)
2006-05-04 16:42:25.858 Camino[367] CFLog (22): Cannot find function
pointer PluginFactoryFunction for factory
1174DEAA-495B-11D5-83E5-000A27E3C238 in CFBundle/CFPlugIn 0x79aa480
</Library/Printers/PPD Plugins/HPColorQuality.plugin> (bundle, not loaded)

He says he has this problem often (but, not always) when he opens multiple tabs to print each one, so maybe that is somehow related.

Also, on each startup he gets "Unable to set languages - language 'English' not a valid ISO language identifier"

I imagime a permissions repair and a fresh profile would be a good idea if none of this leads to any concrete conclusions.
(In reply to comment #5)
> Also, on each startup he gets "Unable to set languages - language 'English' not
> a valid ISO language identifier"

This is due to a machine having been upgraded from 10.1 or below (which used non-standard identifiers); the fix is to remove all the languages from the Languages box in the Language tab of the International pane in System Prefs and then re-add the languages you want.
But it's also entirely unrelated to this.
Any chance this is hardware-related (sticky/malfunctioning shift key)?

To "work around" this problem, you can enable the warning when closing windows full of tabs (in General prefs) and still see when you have the problem but not lose all the tabs/window....
i actually just experienced this myself. it is NOT a sticking shift key, because when you open multiple tabs in the same window and then click on File, the menu doesn't update the keystrokes - Close Window still says Cmd-W, and Close Tab, while active, has no keystroke assigned to it.
a few things from console:
2006-07-07 11:59:27.504 iPIX Browser Plug-In V7.0[3218] osError = 0
/Applications/Camino.app/Contents/MacOS/Camino: can't map file: /Library/Internet Plug-Ins/ipxBrowserPlugin ((os/kern) invalid argument)
2006-07-07 12:01:40.774 Camino[3428] *** _NSAutoreleaseNoPool(): Object 0x526f550 of class NSCarbonWindowContentView autoreleased with no pool in place - just leaking
2006-07-07 12:01:40.777 Camino[3428] *** _NSAutoreleaseNoPool(): Object 0x7e00d00 of class NSCFArray autoreleased with no pool in place - just leaking
... more of the same ...
2006-07-07 12:04:13.985 Camino[3428] *** _NSAutoreleaseNoPool(): Object 0x528b170 of class NSCarbonWindow autoreleased with no pool in place - just leaking
/Applications/Camino.app/Contents/MacOS/Camino: can't map file: /Users/paulb/Library/Internet Plug-Ins/PDF Browser Plugin.plugin ((os/kern) invalid argument)

restarting Camino restores normal operation.
Paul, can you provide more specific steps?  I wasn't able to reproduce this based on my interpretation of your report.  This sounds like it could be some obscure variation of bug 337963 we've yet to trigger (that only happens when opening tab 2, and only for a brief second).
(In reply to comment #10)
> Paul, can you provide more specific steps?
> 
lol, not really. i just happened to notice this because i pressed cmd-w and all my 4 tabs got closed. however, i didn't notice when this actually started happening. it might be the doing of some plugin, maybe something else. like i said, restarting camino fixes the issue. i'll try to keep track of it, but the problem is that i often have browser sessions that last days, because i rarely restart the computer and never quit the app, making it that much harder to figure out what exactly triggered this behavior. if it pops up again, i'll post back here.
Hmm, I wonder if there's some plugin (or a bad PDE in Adam's case) doing Carbon window junk behind our back again and maybe it's confusing the menus.  Not sure what those NSAutoreleaseNoPool Console.log messages mean exactly...Simon?
Could be. I'd also have folks disable Java, just in case JEP is doing Carbon Event handler crap behind our backs.
Adam/Chris, are you still seeing this?
Adam hasn't mentioned it and I have not seen it anywhere else.  Seems to be a non-issue now.
Closing WFM then.  If anyone sees this again, please try to remember what the other tabs were and check for any messages in the console.log (and reopen the bug).
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
This happens if you do full screen in a youtube video, then exit full screen, then press command-w.
(In reply to comment #17)
> This happens if you do full screen in a youtube video, then exit full screen,
> then press command-w.

That's bug 432983.
I just experienced this bug on 2.0b2. Nothing in Console. I've experienced this bug twice, but its been more than a month since I've seen it the last time..
You need to log in before you can comment on or make changes to this bug.