Closed Bug 336678 Opened 18 years ago Closed 18 years ago

Events sometimes pasted to the wrong day

Categories

(Calendar :: Sunbird Only, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

Details

Attachments

(1 file)

Everyone hates jsDate, and here's one more reason.

Pasting events will sometimes place events on the wrong day if it is currently a different day in UTC than the date in your local timezone.  Patch coming.
Attached patch use new view attribute — — Splinter Review
Just get the selectedday directly from the views.  Before, calling jsDateToDateTime on something with isDate == true caused problems.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #220868 - Flags: first-review?(mvl)
Comment on attachment 220868 [details] [diff] [review]
use new view attribute

r=mvl
Attachment #220868 - Flags: first-review?(mvl) → first-review+
Whiteboard: [needs landing]
With Sunbird 0.3a2 RC2 w2k, for New Zealand (UTC+12) ALL paste attempts prior to midday need to be pasted a day earlier, works fine after midday (local).

Tested (before and after midday) for the following events:
  1:am-2:am,
  3:am-4:am,
  7:am-11:pm,
  11:pm-4:am (over two days)
Further testing on latest nightly (20060508 Sunbird 0.3a2) ..

(please note: un-intended test for this bug, just using calendar)

Attempt to copy/paste event that is 'all-day', event pastes as 12:00pm (previous day) to 12:00pm (day pasted), and 'all-day' no longer ticked.

Required work around (order very important):
  (a.) edit/correct  From  date,
  (b.) edit/correct  To  date (changed by step (a.))
  (c.) re-tick 'all-day', and save

Also noted (happened once, but NOT repeatable):

  re-edit of  location  field, reverted to LOSS of 'all-day' setting.  This could be the '5 second' effect, of editing being change is 'posted'!?

See also bug 335882 comment 5 (not directly related, but occured at same time)  
Patch checked in on trunk and MOZILLA_1_8_BRANCH 
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: