Created attachment 220875 [details] [diff] [review] patch This compiles in vc6 for 1.8 branches and vc8 on the trunk. trunk definitely gets symbols in stacks. I haven't tested 1.8.* crashes for stacks yet though.
Comment on attachment 220875 [details] [diff] [review] patch I am not sure what I was doing before but may have run the wrong instance of js, since I am unable to load symbols from js32.dll with this patch.
Created attachment 220887 [details] [diff] [review] patch v2 add pdb for the exe and lib output
Comment on attachment 220887 [details] [diff] [review] patch v2 most things seem to have FOO = bar instead of FOO=bar at least from context.
Created attachment 220924 [details] [diff] [review] patch v3 with timeless' comment addressed.
Comment on attachment 220924 [details] [diff] [review] patch v3 My MSVC fu is not as strong as some possibilities, but this seems right to me!
Attachment #220924 - Flags: review?(mrbkap) → review+
Comment on attachment 220924 [details] [diff] [review] patch v3 timeless, would you mind adding your +- to this?
Comment on attachment 220924 [details] [diff] [review] patch v3 js\src\config>patch.exe --dry-run -R < ..\patch patching file `WINNT4.0.mk' patching file `WINNT5.0.mk' patching file `WINNT5.1.mk' patching file `WINNT5.2.mk' Directory of js\src\Debug 05/11/06 09:43 PM 1,379,328 js32.pdb 05/11/06 09:43 PM 265,216 jsshell.pdb 05/11/06 09:43 PM 184,320 vc80.pdb So something is still creating a vc80.pdb. i can't figure out who based on strings (jsshell.pdb references vc80.pdb by name, but doesn't seem to reference js32.pdb (it does reference js32.dll). yeah, i'm using the vc2k5 free edition plus a may psdk
These are the pdbs I see. ./WINNT5.1_DBG.OBJ/js.pdb ./WINNT5.1_DBG.OBJ/jsapi.pdb ./WINNT5.1_DBG.OBJ/jsarena.pdb ./WINNT5.1_DBG.OBJ/jsarray.pdb ./WINNT5.1_DBG.OBJ/jsatom.pdb ./WINNT5.1_DBG.OBJ/jsbool.pdb ./WINNT5.1_DBG.OBJ/jscntxt.pdb ./WINNT5.1_DBG.OBJ/jsdate.pdb ./WINNT5.1_DBG.OBJ/jsdbgapi.pdb ./WINNT5.1_DBG.OBJ/jsdhash.pdb ./WINNT5.1_DBG.OBJ/jsdtoa.pdb ./WINNT5.1_DBG.OBJ/jsemit.pdb ./WINNT5.1_DBG.OBJ/jsexn.pdb ./WINNT5.1_DBG.OBJ/jsfun.pdb ./WINNT5.1_DBG.OBJ/jsgc.pdb ./WINNT5.1_DBG.OBJ/jshash.pdb ./WINNT5.1_DBG.OBJ/jsinterp.pdb ./WINNT5.1_DBG.OBJ/jskwgen.pdb ./WINNT5.1_DBG.OBJ/jslock.pdb ./WINNT5.1_DBG.OBJ/jslog2.pdb ./WINNT5.1_DBG.OBJ/jslong.pdb ./WINNT5.1_DBG.OBJ/jsmath.pdb ./WINNT5.1_DBG.OBJ/jsnum.pdb ./WINNT5.1_DBG.OBJ/jsobj.pdb ./WINNT5.1_DBG.OBJ/jsopcode.pdb ./WINNT5.1_DBG.OBJ/jsparse.pdb ./WINNT5.1_DBG.OBJ/jsprf.pdb ./WINNT5.1_DBG.OBJ/jsregexp.pdb ./WINNT5.1_DBG.OBJ/jsscan.pdb ./WINNT5.1_DBG.OBJ/jsscope.pdb ./WINNT5.1_DBG.OBJ/jsscript.pdb ./WINNT5.1_DBG.OBJ/jsstr.pdb ./WINNT5.1_DBG.OBJ/jsutil.pdb ./WINNT5.1_DBG.OBJ/jsxdrapi.pdb ./WINNT5.1_DBG.OBJ/jsxml.pdb ./WINNT5.1_DBG.OBJ/prmjtime.pdb brendan said to go ahead and check in since people need this now. we can fix the nits later if need be. Checking in WINNT4.0.mk; /cvsroot/mozilla/js/src/config/WINNT4.0.mk,v <-- WINNT4.0.mk new revision: 1.14; previous revision: 1.13 done Checking in WINNT5.0.mk; /cvsroot/mozilla/js/src/config/WINNT5.0.mk,v <-- WINNT5.0.mk new revision: 1.8; previous revision: 1.7 done Checking in WINNT5.1.mk; /cvsroot/mozilla/js/src/config/WINNT5.1.mk,v <-- WINNT5.1.mk new revision: 1.4; previous revision: 1.3 done Checking in WINNT5.2.mk; /cvsroot/mozilla/js/src/config/WINNT5.2.mk,v <-- WINNT5.2.mk new revision: 1.3; previous revision: 1.2 done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Comment on attachment 220924 [details] [diff] [review] patch v3 i'm clearing this request, i didn't r- it and the patch is in cvs.
You need to log in before you can comment on or make changes to this bug.