Closed
Bug 336832
Opened 18 years ago
Closed 18 years ago
set pref defaults for safe browsing
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: tony, Assigned: tony)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 3 obsolete files)
9.78 KB,
patch
|
Details | Diff | Splinter Review |
Safe browsing should be on by default in non-enhanced mode (using locally downloaded lists).
Assignee | ||
Comment 1•18 years ago
|
||
Turn on pref values. Also change the client id so we can differentiate between firefox users and extension users.
Attachment #221033 -
Flags: review?(bugs)
Attachment #221033 -
Flags: approval-branch-1.8.1?(bugs)
Assignee | ||
Updated•18 years ago
|
Attachment #221033 -
Flags: review?(bugs)
Attachment #221033 -
Flags: approval-branch-1.8.1?(bugs)
Assignee | ||
Updated•18 years ago
|
Attachment #221033 -
Attachment is obsolete: true
Assignee | ||
Comment 2•18 years ago
|
||
Turn on pref values. Also change the client id so we can differentiate between firefox users and extension users. Let's use the right file this time.
Attachment #221038 -
Flags: review?(bugs)
Attachment #221038 -
Flags: approval-branch-1.8.1?(bugs)
Assignee | ||
Comment 3•18 years ago
|
||
Moving prefs from safebrowsing.* to browser.safebrowsing.* Change default to off.
Attachment #221038 -
Attachment is obsolete: true
Attachment #221361 -
Flags: review?(bugs)
Attachment #221361 -
Flags: approval-branch-1.8.1?(bugs)
Attachment #221038 -
Flags: review?(bugs)
Attachment #221038 -
Flags: approval-branch-1.8.1?(bugs)
Comment 4•18 years ago
|
||
Comment on attachment 221361 [details] [diff] [review] default to off r+a=ben@mozilla.org
Attachment #221361 -
Flags: review?(bugs)
Attachment #221361 -
Flags: review+
Attachment #221361 -
Flags: approval-branch-1.8.1?(bugs)
Attachment #221361 -
Flags: approval-branch-1.8.1+
Comment 5•18 years ago
|
||
Attachment #221361 -
Attachment is obsolete: true
Comment 7•18 years ago
|
||
As per a conversation with schrep on IRC, we've changed the default for safebrowsing to be enabled in default (ie: not live checking) mode. Brett's new patch inherits r+a since he just changed four letters.
Comment 8•18 years ago
|
||
For the avoidance of doubt, as of the a2 milestone we're planning on safe browsing being enabled by default in non-enhanced mode only, i.e. checking lists but not passing URLs for server-side checking. This is what we're calling "default mode" for this feature.
Comment 9•18 years ago
|
||
Comment on attachment 221391 [details] [diff] [review] Default to on >Index: browser/app/profile/firefox.js >+#ifdef MOZ_SAFE_BROWSING >+// Safe browsing does nothing unless both these prefs are set. >+pref("browser.safebrowsing.enabled", true); >+pref("browser.safebrowsing.remoteLookups", false); Does it really "do nothing" if the remoteLookups pref is set to false? Comments in this bug say it checks against locally downloaded lists. So the comment for the remoteLookups pref should probably say "also send URLs to the specified remote safebrowsing provider".
Assignee | ||
Comment 10•18 years ago
|
||
(In reply to comment #9) > Does it really "do nothing" if the remoteLookups pref is set to false? The comment means that if either pref is not set/undefined, it does nothing. You are correct that if remoteLookups is set to false, it downloads lists.
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•