Closed Bug 336832 Opened 18 years ago Closed 18 years ago

set pref defaults for safe browsing

Categories

(Toolkit :: Safe Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: tony, Assigned: tony)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 3 obsolete files)

Safe browsing should be on by default in non-enhanced mode (using locally downloaded lists).
Attached patch browser prefs (obsolete) — Splinter Review
Turn on pref values.  Also change the client id so we can differentiate between firefox users and extension users.
Attachment #221033 - Flags: review?(bugs)
Attachment #221033 - Flags: approval-branch-1.8.1?(bugs)
Attachment #221033 - Flags: review?(bugs)
Attachment #221033 - Flags: approval-branch-1.8.1?(bugs)
Attachment #221033 - Attachment is obsolete: true
Attached patch default prefs (obsolete) — Splinter Review
Turn on pref values.  Also change the client id so we can differentiate between
firefox users and extension users.

Let's use the right file this time.
Attachment #221038 - Flags: review?(bugs)
Attachment #221038 - Flags: approval-branch-1.8.1?(bugs)
Blocks: 336273
Attached patch default to off (obsolete) — Splinter Review
Moving prefs from safebrowsing.* to browser.safebrowsing.*  Change default to off.
Attachment #221038 - Attachment is obsolete: true
Attachment #221361 - Flags: review?(bugs)
Attachment #221361 - Flags: approval-branch-1.8.1?(bugs)
Attachment #221038 - Flags: review?(bugs)
Attachment #221038 - Flags: approval-branch-1.8.1?(bugs)
Comment on attachment 221361 [details] [diff] [review]
default to off

r+a=ben@mozilla.org
Attachment #221361 - Flags: review?(bugs)
Attachment #221361 - Flags: review+
Attachment #221361 - Flags: approval-branch-1.8.1?(bugs)
Attachment #221361 - Flags: approval-branch-1.8.1+
Attached patch Default to onSplinter Review
Attachment #221361 - Attachment is obsolete: true
Fixed on branch, leaving bug open for trunk checkin.
Keywords: fixed1.8.1
As per a conversation with schrep on IRC, we've changed the default for safebrowsing to be enabled in default (ie: not live checking) mode. Brett's new patch inherits r+a since he just changed four letters.
For the avoidance of doubt, as of the a2 milestone we're planning on safe browsing being enabled by default in non-enhanced mode only, i.e. checking lists but not passing URLs for server-side checking.  This is what we're calling "default mode" for this feature.
Comment on attachment 221391 [details] [diff] [review]
Default to on

>Index: browser/app/profile/firefox.js
>+#ifdef MOZ_SAFE_BROWSING
>+// Safe browsing does nothing unless both these prefs are set.
>+pref("browser.safebrowsing.enabled", true);
>+pref("browser.safebrowsing.remoteLookups", false);
Does it really "do nothing" if the remoteLookups pref is set to false? Comments in this bug say it checks against locally downloaded lists. So the comment for the remoteLookups pref should probably say "also send URLs to the specified remote safebrowsing provider".
(In reply to comment #9)
> Does it really "do nothing" if the remoteLookups pref is set to false?

The comment means that if either pref is not set/undefined, it does nothing.  You are correct that if remoteLookups is set to false, it downloads lists.

On trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: