Closed Bug 336845 Opened 18 years ago Closed 18 years ago

Removed unused Calendar preference alerts.height

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jason.barnabe, Assigned: mattwillis)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

rev1 - REALLY the right patch
1.08 KB, patch
mvl
: first-review+
Details | Diff | Splinter Review 
The alerts.height preference hasn't done anything since bug 132731 was fixed.
We should remove it. I'd write the patch myself, but I don't build Calendar.
Attached patch rev0 - removes alert.height (obsolete) — — Splinter Review 
Reporter is correct. This pref is no longer used... like for years now.
Assignee: nobody → mattwillis
Status: NEW → ASSIGNED
Attachment #228646 - Flags: first-review?(jminta)
Comment on attachment 228646 [details] [diff] [review]
rev0 - removes alert.height 

>Index: calendar/sunbird/app/profile/sunbird.js
>-pref("calendar.alarms.show", true);
>-pref("calendar.alarms.showmissed", true);
>-pref("calendar.alarms.playsound", true);

you are removing an awful lot more then just the one pref. Are you sure that's what you want?
Comment on attachment 228646 [details] [diff] [review]
rev0 - removes alert.height 

Bad patch
Attachment #228646 - Flags: first-review?(jminta)
Comment on attachment 228646 [details] [diff] [review]
rev0 - removes alert.height 

Bad patch
Attachment #228646 - Attachment is obsolete: true
Attached patch rev1 - the Right patch (obsolete) — — Splinter Review 

        Attachment #228672 -
        Flags: first-review?(mvl)

    
    

    
  
Comment on attachment 228672 [details] [diff] [review]
rev1 - the Right patch

I lied.

        Attachment #228672 -
        Attachment is obsolete: true

        Attachment #228672 -
        Flags: first-review?(mvl)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        rev1 - REALLY the right patch
        — 
          — Splinter Review
      

    


  

        Attachment #228673 -
        Flags: first-review?(mvl)

    
    

    
  
Comment on attachment 228673 [details] [diff] [review]
rev1 - REALLY the right patch

r=mvl

        Attachment #228673 -
        Flags: first-review?(mvl) → first-review+

    
    

    
  
patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: