Closed Bug 336940 Opened 18 years ago Closed 18 years ago

Calling ExtractFile on non-files

Categories

(Core :: Networking: File, defect)

Product:
Core
Component:
Networking: File
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED DUPLICATE of bug 336691

People

(Reporter: bzbarsky, Unassigned)

References

Details

STEPS TO REPRODUCE:

1)  Compile a debug build of Firefox
2)  Go to https://addons.mozilla.org/firefox/1865/
3)  Install the XPI
4)  Have the install thread get killed by PR_Assert

In particular, I hit this:

  Assertion failure: !item->isDirectory, at
  ../../../mozilla/modules/libjar/nsZipArchive.cpp:632

In this case, nsZipArchive::Test has been called with aEntryName=0x0.  So we test all the entries, which includes directories in this case.  And you can't call ExtractFile on directories, of course.

I'm not sure what this code wants to be doing.  Maybe the assert needs to be modified, maybe we need to factor the testing code out, maybe something else.  In any case, this is blocking me debugging bug 336875, because the extension install fails...

*** This bug has been marked as a duplicate of 336691 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.