336993 - crash [@ main] "path" Pointer dereferenced before NULL check

Status: RESOLVED DUPLICATE of bug 387450

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[timeless]

There's also an oom crash floating around here, but most importantly the rv from ParseURL wasn't checked, so path wasn't ensured, once it's checked, the later null check on path is useless.

Comment 1

[timeless]

Attachment: deal w/ oom

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 221199 [details] [diff] [review]
deal w/ oom

>+            if (NS_FAILED(rv))

Don't use NS_FAILED -- these are a different set of enum status values, not nsresults. Should be 
              if (rv != nsHTTPConn::OK);
In case someone later adds a positive failure code. ditto later.