I have a patch which is almost ready. I still have to test it. I will probably attach it either today or tomorrow.
Status: NEW → ASSIGNED
Created attachment 222928 [details] [diff] [review] patch, v1
Attachment #222928 - Flags: review?(mkanat)
Comment on attachment 222928 [details] [diff] [review] patch, v1 Looks good. We really need to do a lot of cleanup. I'm hoping some of that editflagtypes code will get cleaned up when we remove get_product_*. Also, we really need to start passing Bugzilla::BugMail a Bug object, instead of using all that direct SQL and crazy stuff. And I'm hoping that post_bug and process_bug will stop being so ridiculous once all of their code is inside of Bugzilla::Bug.
Attachment #222928 - Flags: review?(mkanat) → review+
Oh, also, I didn't test bug_email.pl, but that's broken already anyway. I trust you.
Checking in editflagtypes.cgi; /cvsroot/mozilla/webtools/bugzilla/editflagtypes.cgi,v <-- editflagtypes.cgi new revision: 1.35; previous revision: 1.34 done Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.367; previous revision: 1.366 done Checking in post_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v <-- post_bug.cgi new revision: 1.145; previous revision: 1.144 done Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.319; previous revision: 1.318 done Checking in request.cgi; /cvsroot/mozilla/webtools/bugzilla/request.cgi,v <-- request.cgi new revision: 1.32; previous revision: 1.31 done Checking in Bugzilla/BugMail.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v <-- BugMail.pm new revision: 1.75; previous revision: 1.74 done Checking in contrib/bug_email.pl; /cvsroot/mozilla/webtools/bugzilla/contrib/bug_email.pl,v <-- bug_email.pl new revision: 1.35; previous revision: 1.34 done Checking in template/en/default/global/code-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v <-- code-error.html.tmpl new revision: 1.67; previous revision: 1.66 done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.