33706 - add 'callback channel' attribute to nsIChannel interface

Status: VERIFIED INVALID

(Core :: Networking, enhancement, P5)

Description

[Warren Harris]

We talked about this in our group meeting last week... We should add an accessor 
to nsIChannel to allow us to set channel argument used in the event sink 
callbacks. Right now, down deep in the transports, they do something like this:

  mUserListener->OnStartRequest(this, mUserContext);

but if they could do this:

  mUserListener->OnStartRequest(mUserChannel, mUserContext);

it would allow us to avoid a whole layer of nsIStreamListener implementation in 
the channel implementations. (Look at nsFileChannel for an example.)

Note that this change might have be done hand-in-hand with one to change the way 
load groups are managed since the OnStopRequest often removes the current 
channel from the load group in addition to passing the OnStopRequest 
notification upstream.

Comment 1

[Warren Harris]

Enhancement for protocol writers.

Comment 2

[benc]

Open Networking bugs, qa=tever -> qa to me.

Comment 3

[Doug Turner (:dougt)]

to darin, the keeper of nsIChannel

Comment 4

[Darin Fisher]

-> future

Comment 5

[Darin Fisher]

this is now pretty much invalid given architectural changes in necko, but the
general idea might still be applicable to nsIInputStreamPump, but nearly all of
our channels do non-trivial stuff in OnStopRequest... usually releasing owning
refs to stuff.  therefore, marking INVALID.

Comment 6

[benc]

V/per Darin.