337131 - search.png needs visual refresh

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[hhh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060508 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060508 Minefield/3.0a1

In the Search bar, the searchbutton icon is ugly, needs a new image. May I suggest the image already in classic.jar named Search-bar.png (you can horizontally flip it if you want to keep the current orientation)?



Reproducible: Always

Comment 1

[hhh]

Attachment: Search-bar.png (flipped)

Comment 2

[hhh]

Attachment: Search.png resized and transparent background added

Comment 3

[u88484]

I agree it needs some color. But there is another icon that will be introduce that turns the current icon red when a search engine is detected on a page that can be installed.

Comment 4

[Pam Greene]

Attachment: New Search.png for winstripe theme

Thanks for the icons, Hass.  Here's a version with an alpha channel.  Chances are it'll be redone along with the whole theme anyway, but just in case...

Comment 5

[Pam Greene]

Attachment: New Search-add-engines.png for winstripe theme

This one should probably also be redone by a better artist than I am.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 221324 [details]
New Search-add-engines.png for winstripe theme

Works fine for now, since they'll probably change later.

Comment 7

[Dão Gottwald [:dao]]

Attachment: Search.png

That's my proposal.

Comment 8

[Dão Gottwald [:dao]]

Attachment: Search-add-engines.png

Comment 9

[u88484]

Nice Dao, a lot easier to tell the difference between the two.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 221324 [details]
New Search-add-engines.png for winstripe theme

this works ok, they might get swizzled again by the visual refresh

Comment 11

[Dão Gottwald [:dao]]

Might? Have to.

Actually, compared to attachment 221324 [details], I prefer the initial Search-add-engines.png.

Comment 12

[Pam Greene]

fixed-1.8-branch, fixed-on-trunk

I'm sure it'll be changed again for b2 (see bug 339735), but in the meantime winstripe shouldn't be using the icon intended for pinstripe.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

The new "highlighted" icon shown when there are engines available to be installed is now barely distinguishable from the normal icon, so it's a lot less noticeable.      

Comment 14

[Stebs]

Also, wouldn't it be wiser to take another color than the red "Danger!" one?
Maybe green and perhaps some + sign above the magnifying glass would make it easier to understand what this notification is all about. (at least that was the tenor in an Mozillazine thread) 

Comment 15

[Dão Gottwald [:dao]]

(In reply to comment #14)

That's bug 339735.