Plugin PrefManager objects leak observer

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: bugzilla-mozilla-20000923, Assigned: bugzilla-mozilla-20000923)

Tracking

({memory-leak})

Trunk
memory-leak

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.74])

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Rah!

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/irc/js/lib/pref-manager.js&rev=1.13&mark=87#77

That object is leaked for all plugin PrefManagers, because none of them get added to client.prefManagers, which is what is used to enumerate and clean up on exit. I have no idea what is actually leaked with it, but it's trivial to fix.
(Assignee)

Comment 1

13 years ago
Created attachment 221334 [details] [diff] [review]
Don't leak plugin PrefManagers

Note that I've also added the branchName (string) to the object that is passed into native-land. This was how I figured out which object got leaked, and I think it would probably be quite sensible to always have a clear identifcation string on all objects that are at risk of leaking.
Attachment #221334 - Flags: review?(samuel)

Updated

13 years ago
Attachment #221334 - Flags: review?(samuel) → review+
(Assignee)

Comment 2

13 years ago
Checked in --> FIXED.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.74]
You need to log in before you can comment on or make changes to this bug.