337261 - Review dom_storage build changes on the Camino/1.8 branch

Status: RESOLVED WORKSFORME

(Camino Graveyard :: General, defect)

Description

[Asaf Romano (gone)]

I did some checkins in order to fix the build bustage from bug 335540:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=project.pbxproj&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=mozilla/camino/Camino.xcode&command=DIFF_FRAMESET&rev1=1.89.2.24&rev2=1.89.2.25
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=configure.in&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=mozilla&command=DIFF_FRAMESET&rev1=1.1503.2.62&rev2=1.1503.2.63
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=basebrowser-mac-macho&branch=MOZILLA_1_8_BRANCH&root=/cvsroot&subdir=mozilla/embedding/config&command=DIFF_FRAMESET&rev1=1.44.4.4&rev2=1.44.4.5

Those are branch-only for now since bug 335540 was not checked in on trunk.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

It would be really good if we could get some documentation (for our soon-to-be-improved cb.o development section) on how to add new Gecko components and extensions to Camino, not just for catastrophic after-hours bustage fixes but also for newer devs who need to do this when they add features based on new moz components/extensions (e.g., we spent several nights on irc when Julian was working on spellcheck).

Comment 2

[Mark Mentovai]

r=mento.  Thanks for the bustage fix.  I guess we'll see how much larger this makes the package.

Comment 3

[Asaf Romano (gone)]

This was backed out, but now storage is in again (this means Camino now has support for session storage but not for global storage).

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

What needs to be done here yet?  Something related to Mano's comment 3?  Or can this be closed?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

mento, can we close this?

Comment 6

[froodian (Ian Leue)]

Pushing to 2.0, since we don't know if this even needs to be open.  (As always, comments to that effect are welcomed)