337351 - Search bar fills the entire toolbar even though there is a flexible space

Status: RESOLVED INVALID

(Toolkit :: View Source, defect)

Description

[the-edmeister]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1a2) Gecko/20060509 BonEcho/2.0a2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1a2) Gecko/20060509 BonEcho/2.0a2

The Flexible Space isn't flexible. When dragged to a Toolbar the Flexible Space doesn't expand and appears to be 1/3 the width of a 'regular' Space. Doesn't expand when the Customize dropdown is closed.

Reproducible: Always

Steps to Reproduce:
1.URL box moved to the Menu Bar, Navigation bar empty except for Navigation Icons and Search Box
2.Existing 2.0a1 Profile first noticed this regression.
3.New Profile same results.

Actual Results:  
Search Box expands to available width of the Navigation bar.

Expected Results:  
I was hoping this was an issue with 'bumped' extensions, but was able to reproduce with a new Profile.

Comment 1

[Adam Kowalczyk]

Flexible space works ok. This particular behavior is caused by flex changes in Bug 258679 and it is intended. The same thing happens with the Location Bar.

CC'ing Joe Hughes, just to be 100% sure. Could you please verify this?

Comment 2

[the-edmeister]

The problem first occurred when the new Search Box hit the Branch (no problem on the Minefield Trunk). Have done 3 updates since the problem originally surfaced, still present. Did a fresh installation of 2.0a2 2006051103 on W2K and started another fresh Profile, no difference, Flexible Space not expanding. If it makes any difference I run dual boot, Win98 [rarely used anymore]on C:\ (D:\ is my Data drive) and W2K on E:\. I use Zip-builds exclusively and all are un-Zipped into a freshly created folder.

Flexible Space not expanding is when either the Search Box or the URL Box are on the Nav Bar. The Flex Space appears as 1/2 the size of a Space - it doesn't expand when dragged or when Customize is closed. 

If 3 icons from the Customize dropdown are placed on the Nav Bar, a Fleixible Space can be inserted between them and the Flexible Space's do expand properly to position the icons left, center, and right.

I don't feel this has any relationship to Bug 258679 as the Search Box (or URL box) does narrow correctly when the browser window is minimized.

Comment 3

[Joe Hughes]

(In reply to comment #2)

Ed, this is happening because while the searchbox used to not resize at all (leaving all the available width for the flexible space), it now has a flex factor of 100.  Since (IIRC) the flexible space only has a flex factor of 1, the searchbar dominates the available space.

I'm curious--what are you looking to do with this behavior?

Comment 4

[the-edmeister]

I use either Compact Menu or Tiny Menu to reduce the Menu items into a dropdown Menu, then I move the URL bar and all the Nav bar icons to the Menu bar leaving only the Search Box on the Nav bar, along with some function icons. I am able to do most of my browsing with only one Toolbar showing, but when I want to use the Search Box (or access any icons I may place on the Nav bar) I un-hide the Nav bar. I never use the Bookmarks Toolbar, all my Bookmark activity takes place from the Sidebar (still figuring out a new routine for Minefield & Places). I don't want to waste the browser window looking at stuff I know is there and can access thru keyboard commands. The keyboard commands work when running in Full Screen with the Autohide extension.

Ok, so now I understand what is happening, the URL box and the Search box have an unlimited size range (flex factor of 100), thus 'they' override the Flexible Space's ability to expand. This change caught me by surprise as I am also running the Minefield Nightly's which got the new Search Box 2 days previous to 'it' hitting the Bon Echo Branch, but I didn't see this 'flex factor of 100' on Minefield until today - 3.0a1 2006051208 build.

Thanks for the clarification, I will find a work-around to limit how much Toolbar space is allowed for those boxes.
Resolved as invalid, expected results (that took me by surprise <grin>)

Comment 5

[Tanner M. Young [:tmyoung]]

Resetting QA contact to default.