337371 - combine url classifier tables into a single component

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Tony Chang (Google)]

There are three url classifier tables, url, domain, and enchash.  We're currently loading this as three separate JS components and using the JS subscript loader to load files it depends on.  We should use one component to cut back on duplicate file loading and to speed up start up.

Comment 1

[Tony Chang (Google)]

Attachment: combine 3 components into 1

Combine into a single component with a more moz-like name (nsUrlClassiferTable.js).  Move table logic into trtable.js so component only deals with loading.

While I'm at it, remove threadqueue.js which we no longer use.

Comment 2

[Darin Fisher]

Comment on attachment 221516 [details] [diff] [review]
combine 3 components into 1

mozilla/toolkit/components/url-classifier/content/trtable.js

>+UrlClassifierTableDomain.prototype.exists = function(url, callback) {
>+  var urlObj = Cc["@mozilla.org/network/standard-url;1"]
>+               .createInstance(Ci.nsIURL);
>+  urlObj.spec = url;
>+  var host = urlObj.host;
>+  var components = host.split(".");

It is generally a bad idea to instantiate the Standard URL object 
directly to parse hostnames like this.  Instead, you should use
nsIIOService's newURI method.  That way, you are sure to use the
correct URL parser.


r=darin w/ that change

Comment 3

[Tony Chang (Google)]

Attachment: combine 3 components into 1

add in darin's change

Comment 4

[Tony Chang (Google)]

Attachment: combine 3 components into 1

forgot to remove thread-queue.js from urlListManager.js

Comment 5

[Brett Wilson]

Fixed on trunk. Leaving open so we don't forget to check in on branch. Tony: you should ask for branch approval.

Comment 6

[Brett Wilson]

Fixed on branch.