Closed Bug 337375 Opened 18 years ago Closed 18 years ago

session restore disturbs secondary firefox window sizing

Categories

(Firefox :: General, defect)

2.0 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: david.miller, Assigned: dietrich)

References

Details

(Keywords: fixed1.8.1)

Attachments

(3 files)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060509 BonEcho/2.0a2 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060509 BonEcho/2.0a2 After a crash and successful restoration of the Bon Echo session where two Bon Echo windows are currently open (not tabs) the secondary window will not resize properly. Reproducible: Always Steps to Reproduce: 1. Crash Bon Echo as described in bug 337349 2. Restart Bon Echo 3. Restore the session 4. Open the second window Actual Results: The first window will take focus and cover up the taskbar completely. The second window will be unable to be maximized. TalkBack ID TB18495137M screenshot(s) of behavior in play are attached to this report.
Version: unspecified → 2.0 Branch
Attached image behavior
Attached image behavior 2
The problem is the null parameter to openWindow in _openWindowWithState. See bug 277798 comment #6. Replacing the null with an empty nsISupportsString fixes the issue: var argString = Cc["@mozilla.org/supports-string;1"].createInstance(Ci.nsISupportsString); argString.data = ""; ....openWindow(..., argString);
Status: UNCONFIRMED → NEW
Ever confirmed: true
here's a patch for the fix as simon described it. i can't reproduce the problem on a mac, so i'll get a windows build going and try there.
I'm having the exact same problem. However, the second window also causes Windows to refuse to show the taskbar unless you press CTRL+ESC or the winkey (I have my taskbar on auto-hide). As soon as I close the broken second window, the taskbar reappears correctly when I move my mouse to that side of the screen.
Status: NEW → ASSIGNED
Whiteboard: [checkin needed]
apologies for bugspam
Assignee: nobody → dietrich
Status: ASSIGNED → NEW
This is checked in on trunk. Will request branch check-in after the requisite baking period.
Flags: blocking-firefox2?
Whiteboard: [checkin needed]
Status: NEW → ASSIGNED
Attachment #221655 - Flags: review+
Attachment #221655 - Flags: approval1.8.1+
Flags: blocking-firefox2? → blocking-firefox2+
*** Bug 342678 has been marked as a duplicate of this bug. ***
Checked in on branch.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: