337417 - editor.lib not found; --enable-plaintext-editor-only (windows-only)

Status: RESOLVED INCOMPLETE

(Toolkit Graveyard :: XULRunner, defect)

Description

[Sebastian Tusk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.2) Gecko/20060308 Firefox/1.5.0.2

Building xulrunner on Windows with the option --enable-plaintext-editor-only in .mozconfig leads to a missing library. On linking xul.dll the library editor.lib is not found. Indeed the file is not existent. That is because the library is called texteditor.lib if compiled with --enable-plaintext-editor-only. Changing libxul-config.mk so that xul.dll is linked with texteditor.lib instead of editor.lib fixes this problem.

Reproducible: Always



Expected Results:  
xulrunner should build with the --enable-plaintext-editor-only option.

Comment 1

[Sebastian Tusk]

Attachment: libxul-config.mk patch

Comment 2

[Adam Guthrie]

You're probably going to want to ask for a review of this patch (if you want it in the mozilla.org tree). Benjamin Smedberg would be able to do this ([e-mail]).

Comment 3

[Benjamin Smedberg]

Comment on attachment 221678 [details] [diff] [review]
libxul-config.mk patch

The lib is only renamed on windows. I can't see a good reason for the renaming: http://lxr.mozilla.org/mozilla/source/editor/libeditor/build/Makefile.in#84

Can we just remove the renaming bit from that makefile? (and probably need to update the seamonkey installer packaging lists)