337471 - nsIPasswordManagerInternal.findPasswordEntry is fairly sucky

Status: RESOLVED WONTFIX

(Core :: Networking, enhancement)

Description

[timeless]

1. it claims i can pass null for AString creatures which is dead wrong.
2. it doesn't give me an enumerator, which is really what I need.

/**
 * A Call to find logins in the password manager list that match the
 * specified parameters. Empty input parameters are not tested when
 * looking for matches.
 *
 * @param aHostURI The uri part of a login to search for, or empty
 * @param aUsername The username part of a login to search for, or empty
 * @param aPassword The password part of a login to search for, or empty
 * @returns nsISimpleEnumerator.
 *          Each item will QI to nsIPropertyBag and each bag will have
 *          properties:
 *     host     - The uri found in the login
 *     username - The username found in the login
 *     password - The password found in the login
 */
nsISimpleEnumerator findPasswordEntries(in AUTF8String aHostURI, in AString aUsername, in AString aPassword);

This would enable both the chrome uis standard mozilla.org gecko consumers have to do what they actually want to do, as well as enabling embedding customers to not have to reinvent this functionality.

If people don't want to fix this, then at least fix the interface to properly document what it takes since it *can't* take null.

Comment 1

[timeless]

which of the multitude of properties/propertybags people want to use is something i'm very flexible about :). as well as the flavor of the returned strings from those properties. and i'm certainly flexible about the names of the properties. and if someone really would rather we use a custom spun interface just for the enumerants, that too is perfectly fine with me.