Closed Bug 337633 Opened 18 years ago Closed 18 years ago

Dead code in security/nss/lib/pk11wrap/pk11cert.c

Categories

(NSS :: Libraries, defect, P3)

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 337154
3.11.3

People

(Reporter: kherron+mozilla, Unassigned)

References

()

Details

(Keywords: coverity)

This is coverity CIDs 834, 835, 836, and 837. Please refer to the sample URL.

At line 1087, the test will always fail because it's inside a block testing for the opposite condition. Identical code appears at line 1250 and 1321.

At line 1790, the test will always fail. This code can only execute following a branch to the label |loser|. namelist is always null at any of the points that branch to that label.
Priority: -- → P3
Target Milestone: --- → 3.11.2
Version: unspecified → 3.0
Retargetting all P2s to 3.11.3 .
Target Milestone: 3.11.2 → 3.11.3
Looking at the code can anyone confirm this has been fixed?
Yep, this was fixed in bug 337154.

*** This bug has been marked as a duplicate of 337154 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.