337655 - safe browsing makes start up time really slow

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Tony Chang (Google)]

Most of the startup time that safe browsing adds is in loading and evaluating JS files in a few components.  We can get a significant speed improvement by having large single JS components (rather than the current approach of using the JS subscript loader) which will benefit from JS component fastload.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

SafeBrowsing is now targeted at Bon Echo Alpha 3. Tony, let us know if you think you can make this target (see dev.planning)

Comment 2

[Tony Chang (Google)]

Attachment: v1: preprocess js components

This does two things.  First, we move all the common files into nsSafeBrowserLib.js.  The other modules lazily get a reference to that module and copy over references as needed.

Second, we move from JS subscript loader to #include.

Brian, do you have branch approval powers?  Suggestions on who to ask (maybe after js component fastload is on branch)?

Comment 3

[Tony Chang (Google)]

Comment on attachment 221865 [details] [diff] [review]
v1: preprocess js components

I'm going to break this into two pieces, one for toolkit and one for browser.  This will just be a tracking bug.

Comment 4

[Tony Chang (Google)]

Initial run on SB tinderbox: 771ms
With SB on: 868-967ms (13-25%) !

Comment 5

[Tony Chang (Google)]

No more regression on trunk or branch.