When trying to impersonate someone, the UI displays the password field when using the ENV method (with user_info_class="Env,CGI")

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
User Accounts
P1
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Frédéric Buclin, Assigned: Max Kanat-Alexander)

Tracking

({regression})

2.23
Bugzilla 3.0
regression
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

v2
636 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
From bug 300410 comment 24:

When trying to impersonate someone, relogin.cgi?action=prepare-sudo displays the password field with the ENV method when user_info_class="Env,CGI". The code doesn't care about the password though. Maybe this is only a minor UI thing, but it could also be a more severe bug => severity 'major'.
(Assignee)

Comment 1

12 years ago
Yeah, I think it's only a minor UI thing.
Assignee: user-accounts → mkanat
Severity: major → normal
Priority: -- → P1
(Assignee)

Comment 2

12 years ago
Created attachment 221805 [details] [diff] [review]
v1

Okay, yeah, I just had forgotten to properly fix can_login.
Attachment #221805 - Flags: review?(LpSolit)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 3

12 years ago
Comment on attachment 221805 [details] [diff] [review]
v1

> sub can_login {
>     my ($self) = @_;
>+    my $getter = $self->{_info_getter}->{successful};
>+    $getter    = $self->{_info_getter}
>+        if (!$getter || $getter->isa('Bugzilla::Auth::Login::Cookie'));
>     return $self->{_info_getter}->can_login;
> }


This looks wrong to me. Shouldn't it be:
return $getter->can_login; ?

Else why using $getter?
(Assignee)

Comment 4

12 years ago
Created attachment 221979 [details] [diff] [review]
v2

Oh, you're right. :-)
Attachment #221805 - Attachment is obsolete: true
Attachment #221979 - Flags: review?(LpSolit)
Attachment #221805 - Flags: review?(LpSolit)
(Reporter)

Comment 5

12 years ago
Comment on attachment 221979 [details] [diff] [review]
v2

r=LpSolit
Attachment #221979 - Flags: review?(LpSolit) → review+
(Reporter)

Updated

12 years ago
Flags: approval?
Flags: approval? → approval+
(Reporter)

Comment 6

12 years ago
Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.