337681 - When trying to impersonate someone, the UI displays the password field when using the ENV method (with user_info_class="Env,CGI")

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect, P1)

Description

[Frédéric Buclin]

From bug 300410 comment 24:

When trying to impersonate someone, relogin.cgi?action=prepare-sudo displays the password field with the ENV method when user_info_class="Env,CGI". The code doesn't care about the password though. Maybe this is only a minor UI thing, but it could also be a more severe bug => severity 'major'.

Comment 1

[Max Kanat-Alexander]

Yeah, I think it's only a minor UI thing.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, yeah, I just had forgotten to properly fix can_login.

Comment 3

[Frédéric Buclin]

Comment on attachment 221805 [details] [diff] [review]
v1

> sub can_login {
>     my ($self) = @_;
>+    my $getter = $self->{_info_getter}->{successful};
>+    $getter    = $self->{_info_getter}
>+        if (!$getter || $getter->isa('Bugzilla::Auth::Login::Cookie'));
>     return $self->{_info_getter}->can_login;
> }


This looks wrong to me. Shouldn't it be:
return $getter->can_login; ?

Else why using $getter?

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Oh, you're right. :-)

Comment 5

[Frédéric Buclin]

Comment on attachment 221979 [details] [diff] [review]
v2

r=LpSolit

Comment 6

[Frédéric Buclin]

Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.15; previous revision: 1.14
done