Closed Bug 337681 Opened 18 years ago Closed 18 years ago

When trying to impersonate someone, the UI displays the password field when using the ENV method (with user_info_class="Env,CGI")

Categories

(Bugzilla :: User Accounts, defect, P1)

2.23
defect

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: mkanat)

References

()

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

From bug 300410 comment 24:

When trying to impersonate someone, relogin.cgi?action=prepare-sudo displays the password field with the ENV method when user_info_class="Env,CGI". The code doesn't care about the password though. Maybe this is only a minor UI thing, but it could also be a more severe bug => severity 'major'.
Yeah, I think it's only a minor UI thing.
Assignee: user-accounts → mkanat
Severity: major → normal
Priority: -- → P1
Attached patch v1 (obsolete) — Splinter Review
Okay, yeah, I just had forgotten to properly fix can_login.
Attachment #221805 - Flags: review?(LpSolit)
Status: NEW → ASSIGNED
Comment on attachment 221805 [details] [diff] [review]
v1

> sub can_login {
>     my ($self) = @_;
>+    my $getter = $self->{_info_getter}->{successful};
>+    $getter    = $self->{_info_getter}
>+        if (!$getter || $getter->isa('Bugzilla::Auth::Login::Cookie'));
>     return $self->{_info_getter}->can_login;
> }


This looks wrong to me. Shouldn't it be:
return $getter->can_login; ?

Else why using $getter?
Attached patch v2Splinter Review
Oh, you're right. :-)
Attachment #221805 - Attachment is obsolete: true
Attachment #221979 - Flags: review?(LpSolit)
Attachment #221805 - Flags: review?(LpSolit)
Comment on attachment 221979 [details] [diff] [review]
v2

r=LpSolit
Attachment #221979 - Flags: review?(LpSolit) → review+
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.