337731 - Make gnomefvs use frozen linkage

Status: RESOLVED FIXED

(Core :: Networking: File, defect)

Description

[Benjamin Smedberg]

Because it uses runtime resolution of the optional gnomevfs libraries, it cannot be part of libxul.

Comment 1

[Benjamin Smedberg]

Attachment: Frozen linkage for gnomevfs, rev. 1

Comment 2

[Darin Fisher]

Comment on attachment 222698 [details] [diff] [review]
Frozen linkage for gnomevfs, rev. 1

>Index: extensions/gnomevfs/nsGnomeVFSProtocolHandler.cpp

>+  nsAutoString dispHost = NS_ConvertUTF8toUTF16(scheme);

    NS_ConvertUTF8toUTF16 dispHost(scheme);


>+      mDirBuf.Append(NS_LITERAL_CSTRING("300: "));

Avoid calling NS_LITERAL_CSTRING since it just adds code bloat.
What we really need is AppendLiteral, but in place of that I'd
just call Append("300: ") since that is going to be less code
and plenty efficient.


>+      if (mSpec.get()[mSpec.Length() - 1] != '/')

Hmm... we should define CharAt or maybe even operator[] :-)


>+static void
>+StripWhitespace(nsCString& aString)
>+{

This should be moved into nsStringAPI, no?  At least it should
make use of the APIs you added there.  Perhaps nsStringAPI.h
should have a .Strip method?


>-  PRInt32 colon = spec.FindChar(':');
>-  if (colon == kNotFound)
>+  const char *specstring = aSpec.get();

nit: specString or specStr


r=darin

Comment 3

[Benjamin Smedberg]

Attachment: astring.StripChars(), rev. 1

Ok, this implements the StripChars and StripWhitespace signatures on the external nsAString/nsACString, and unit-tests them.

Comment 4

[Darin Fisher]

Comment on attachment 222797 [details] [diff] [review]
astring.StripChars(), rev. 1

What if BeginWriting fails on |this|?

Comment 5

[Benjamin Smedberg]

BeginWriting can fail? Ugh

Comment 6

[Benjamin Smedberg]

Attachment: astring.StripChars(), rev. 1.1

Comment 7

[Benjamin Smedberg]

I landed this on trunk on 2006-05-23