Closed
Bug 337741
Opened 19 years ago
Closed 19 years ago
safe browsing doesn't need to listen to so many events
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: tony, Assigned: tony)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
20.94 KB,
patch
|
brettw
:
review+
bryner
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The tabbrowserwatcher.js in /browser/components/safebrowsing/content listens to lots of events even though safe browsing only cares about 2 events (document nav start and tabswitch). We should stop listening to all the other events.
|
Assignee | |
Comment 1•19 years ago
|
||
Removing lots of event listeners that we don't need. Also setting web progress listener to only listen for NOTIFY_STATE_REQUEST.
Some other clean ups to simplify the logic.
Attachment #221875 -
Flags: review?(brettw)
Attachment #221875 -
Flags: approval-branch-1.8.1?(bugs)
|
|
||
Updated•19 years ago
|
Attachment #221875 -
Flags: review?(brettw) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #221875 -
Flags: approval-branch-1.8.1?(bugs) → approval-branch-1.8.1?(darin)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #221875 -
Flags: approval-branch-1.8.1?(darin) → approval-branch-1.8.1?(bugs)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #221875 -
Flags: approval-branch-1.8.1?(bugs) → approval-branch-1.8.1?(bryner)
|
|
||
Updated•19 years ago
|
Attachment #221875 -
Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•