337782 - Change the way that whine.pl gets and formats the current date

Status: RESOLVED FIXED

(Bugzilla :: Whining, enhancement)

Description

[Max Kanat-Alexander]

Right now whine.pl does this to get info about the current date:

# get the current date and time from the database
$sth = $dbh->prepare('SELECT ' . $dbh->sql_date_format('NOW()', '%y,%m,%d,%a,%H,%i'));
$sth->execute;
my ($now_year, $now_month, $now_day, $now_weekdayname, $now_hour, $now_minute) =        split(',', $sth->fetchrow_array);
$sth->finish;

That's basically the array version of localtime, with the day name added in. That's ridiculous.

Also, SQLite doesn't support a lot of those % format strings.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Here's another pretty-easy one. I know that at least it compiles, and whine.pl seems to run without errors.

Comment 2

[Kevin Benton]

Comment on attachment 221870 [details] [diff] [review]
v1

Good patch.  Very minor nit: Time::localtime specifies that localtime also returns yday and isdst.  For clarity's sake, you may want to consider adding ", undef, undef" or ", $yday, $isdst" before ") = $localtime;"

Comment 3

[Kevin Benton]

Comment on attachment 221870 [details] [diff] [review]
v1

OOPS - forgot r+

Comment 4

[Max Kanat-Alexander]

Comment on attachment 221870 [details] [diff] [review]
v1

LpSolit, want to do a little super-review on this?

Comment 5

[Max Kanat-Alexander]

(In reply to comment #2)
> (From update of attachment 221870 [details] [diff] [review] [edit])
> you may want to consider adding ",
> undef, undef" or ", $yday, $isdst" before ") = $localtime;" 

  "undef" isn't an lvalue, and the others are just discarded. If I put vars there, perl would give me a "used only once" warning. :-)

  Thanks for the review. :-)

Comment 6

[Frédéric Buclin]

Comment on attachment 221870 [details] [diff] [review]
v1

Here is the output I get with and without your patch applied and with the following line inserted:
print "YEAR: $now_year  MONTH: $now_month  DAY: $now_day  DOW: $now_weekday
       HOUR: $now_hour  MIN: $now_minute\n";


./whine.pl
FROM DB:
YEAR: 06  MONTH: 05  DAY: 16  DOW: 2  HOUR: 17  MIN: 56
FROM localtime():
YEAR: 06  MONTH: 4  DAY: 16  DOW: 2  HOUR: 17  MIN: 56

Note that the month differs, because both MySQL and PostgreSQL return 5 for May, while localtime() returns 4 (0 = January, 11 = December for localtime(), see the docs).

So you have to either increment $now_month by 1 or fix
my @daysinmonth = qw(0 31 28 31 30 31 30 31 31 30 31 30 31);
to remove 0 from the first position (and fix all other places in whine.pl too). The first suggestion is safer, the last one is cleaner.

Comment 7

[Max Kanat-Alexander]

Attachment: v2

Ahh, good catch. I just incremented the month number; much easier with how the rest of the code works.

Comment 8

[Frédéric Buclin]

Comment on attachment 222227 [details] [diff] [review]
v2

r=LpSolit

Comment 9

[Max Kanat-Alexander]

Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.24; previous revision: 1.23
done