Status

--
trivial
VERIFIED FIXED
13 years ago
6 years ago

People

(Reporter: cameron, Assigned: cameron)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

13 years ago
As noted at http://www.mozilla.org/contribute/writing/guidelines#validation -
all mozilla pages should validate as HTML 4.01 Strict.
(Assignee)

Updated

13 years ago
Assignee: nobody → bugs.cameron
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

13 years ago
Created attachment 221888 [details] [diff] [review]
Valid patch

Moved styles inside <style> tag, enclosed paragraphs in <p> ... </p>, made all html tags lowercase, put the <a name> tags around the titles, encoded ampersands in the cvslog url, and added a trailing </html> tag.

Gee that was hard work *wipes brow* Clearly I'm worthy of being included in this list myself... not :)
Attachment #221888 - Flags: review?
--> mozilla.org :: www.mozilla.org
Component: *.mozilla.org → www.mozilla.org
Product: Websites → mozilla.org
Version: unspecified → other
QA Contact: other-mozilla-org → www-mozilla-org
Credits is gerv's domain.
(Assignee)

Updated

13 years ago
Attachment #221888 - Flags: review? → review-
(Assignee)

Comment 4

13 years ago
Created attachment 221889 [details] [diff] [review]
Take 2

Encoded the space in the subject for the email link. Also adjusted it so there's no lines beginnign with "

First one r- is from RSZ.
Attachment #221888 - Attachment is obsolete: true
Attachment #221889 - Flags: review?(bmo)
Comment on attachment 221889 [details] [diff] [review]
Take 2

Good job, thanks.
Attachment #221889 - Flags: review?(bmo) → review+
(Assignee)

Comment 6

13 years ago
RSZ checked this in :)
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
It is generally not done to check into a page which is clearly owned by someone, before they have said it's OK. To see whether a page is clearly owned, look at the CVS log, e.g.:
http://bonsai-www.mozilla.org/cvslog.cgi?file=mozilla-org/html/credits/index.html&rev=&root=/cvsroot/

No harm done in this case, apart from the fact that the CVS log now looks a little uglier, but something to bear in mind for the future.

Gerv
(Assignee)

Updated

13 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 224648 [details] [diff] [review]
Fix Validation issues

This fixes a couple of issues that were introduced in rev 1.265 including adding a </p>, a </body>, and changing & signs to &amp;.
Attachment #224648 - Flags: review?(gerv)
Comment on attachment 224648 [details] [diff] [review]
Fix Validation issues

r=gerv.

Gerv
Attachment #224648 - Flags: review?(gerv) → review+
Checked in.

Checking in index.html;
/cvsroot/mozilla-org/html/credits/index.html,v  <--  index.html
new revision: 1.269; previous revision: 1.268
done

Gerv
Status: REOPENED → RESOLVED
Last Resolved: 13 years ago13 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

13 years ago
Thanks Gerv.
Status: RESOLVED → VERIFIED
The initial checkin in this bug was not an exact checkin of the attached patch. Specifically, the heading for the "E" section was removed in the checked-in version, while it is still present in the attached patch.

Can the patch author (cameron) and the checker-in (bmo@rsz.jp) figure out how this happened, and make sure it doesn't happen again? :-)

I have fixed the "E" problem with a subsequent checkin:

Checking in index.html;
/cvsroot/mozilla-org/html/credits/index.html,v  <--  index.html
new revision: 1.270; previous revision: 1.269
done

Thanks,

Gerv
Product: mozilla.org → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.