337807 - http://www.mozilla.org/credits/ is not valid HTML

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Cameron]

As noted at http://www.mozilla.org/contribute/writing/guidelines#validation -
all mozilla pages should validate as HTML 4.01 Strict.

Comment 1

[Cameron]

Attachment: Valid patch

Moved styles inside <style> tag, enclosed paragraphs in <p> ... </p>, made all html tags lowercase, put the <a name> tags around the titles, encoded ampersands in the cvslog url, and added a trailing </html> tag.

Gee that was hard work *wipes brow* Clearly I'm worthy of being included in this list myself... not :)

Comment 2

[Reed Loden [:reed]]

--> mozilla.org :: www.mozilla.org

Comment 3

[Reed Loden [:reed]]

Credits is gerv's domain.

Comment 4

[Cameron]

Attachment: Take 2

Encoded the space in the subject for the email link. Also adjusted it so there's no lines beginnign with "

First one r- is from RSZ.

Comment 5

[victory <[e-mail]>]

Comment on attachment 221889 [details] [diff] [review]
Take 2

Good job, thanks.

Comment 6

[Cameron]

RSZ checked this in :)

Comment 7

[Gervase Markham [:gerv]]

It is generally not done to check into a page which is clearly owned by someone, before they have said it's OK. To see whether a page is clearly owned, look at the CVS log, e.g.:
http://bonsai-www.mozilla.org/cvslog.cgi?file=mozilla-org/html/credits/index.html&rev=&root=/cvsroot/

No harm done in this case, apart from the fact that the CVS log now looks a little uglier, but something to bear in mind for the future.

Gerv

Comment 8

[Samuel Sidler (old account; do not CC)]

Attachment: Fix Validation issues

This fixes a couple of issues that were introduced in rev 1.265 including adding a </p>, a </body>, and changing & signs to &amp;.

Comment 9

[Gervase Markham [:gerv]]

Comment on attachment 224648 [details] [diff] [review]
Fix Validation issues

r=gerv.

Gerv

Comment 10

[Gervase Markham [:gerv]]

Checked in.

Checking in index.html;
/cvsroot/mozilla-org/html/credits/index.html,v  <--  index.html
new revision: 1.269; previous revision: 1.268
done

Gerv

Comment 11

[Cameron]

Thanks Gerv.

Comment 12

[Gervase Markham [:gerv]]

The initial checkin in this bug was not an exact checkin of the attached patch. Specifically, the heading for the "E" section was removed in the checked-in version, while it is still present in the attached patch.

Can the patch author (cameron) and the checker-in ([e-mail]) figure out how this happened, and make sure it doesn't happen again? :-)

I have fixed the "E" problem with a subsequent checkin:

Checking in index.html;
/cvsroot/mozilla-org/html/credits/index.html,v  <--  index.html
new revision: 1.270; previous revision: 1.269
done

Thanks,

Gerv