337859 - Firefox windows open very small initially, then expand to regular size

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Adam Guthrie]

Steps to reproduce:
1. Open Firefox.

Results:
Window is sized around 100x100px and then resizes to normal window size very quickly.

Expect results:
Open in normal window size.

Regression range: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-05-12+11%3A00&maxdate=2006-05-12+21%3A00&cvsroot=%2Fcvsroot

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 336847; verified by local backout of that patch.

Comment 2

[James Ross]

I've not seen this at all here, and it's got to be a layout bug...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Very possible, but it looks like crap, fucks with the window manager's placement algorithms, and the Firefox window doesn't make a very good layout bug testcase.  If someone can come up with a minimal-ish XUL testcase, that would be nice.

For what it's worth, I really don't see why this CSS change would cause this behavior; I'd think the window size would come from the persistence object... On the other hand, XUL's support for negative margins is not exactly well-tested, so...

Comment 4

[Tuukka Tolvanen (sp3000)]

reverting bug 295447 (and subsequent fixes to it) by commenting out http://lxr.mozilla.org/mozilla/source/widget/src/gtk2/nsWindow.cpp#715 -- 719 fixes this issue also (cf bug 324348)

Comment 5

[Justin Wood (:Callek)]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/widget/src/gtk2/nsWindow.cpp&rev=1.171&root=/cvsroot&mark=715-719#710
Bonsai link for lxr referenced in c#4 (incase stuff changes in lxr)

Comment 6

[Ginn Chen]

I'm sorry to hear this bug returns.
The CSS changes make mNeedsResize become FALSE before the window is focused.

Comment 7

[Ginn Chen]

Attachment: patch

We should check owningWindow's attribute, not |this|'s.
I think mIsShown is much more reliable than mNeedsResize

Comment 8

[Tuukka Tolvanen (sp3000)]

I can confirm that the patch fixes things here. Note while testing that since the css that triggered this issue gives incorrect appearance on gtk (bug 338000), it may go away due to changes there.

Comment 9

[Ginn Chen]

Checking in widget/src/gtk2/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk2/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.172; previous revision: 1.171
done