337909 - Update disabled extensions without restart

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Probably something for the future, but there shouldn't be the need/suggestion to restart firefox when updating a disabled extension.

Comment 1

[Robert Strong (they/them - no direct email)]

I considered this a long time ago and don't see much value in providing this along with it would create a new conditional code path where we already have too many IMO. Instead, working on making restarts unnecessary in all situations would be valuable as in bug 256509.

Do you really see value in doing this?

Comment 2

[Dave Townsend [:mossop]]

I do see value in at least hiding the restart from the user. You have to restart in order to enable the extension anyway, so rather than saying that they have to restart for the update to be applied, why not just leave it as it. Then when they try to enable the standard message about the restart is there and the update will happen during that restart.

Comment 3

[Robert Strong (they/them - no direct email)]

I really wonder about how many different code paths the EM is going to end up with... it is already a mess even with a bunch of the code to control ui removed from it. Once the install without restart is implemented then this will be simple while getting us to the end goal we would prefer. As is controlling whether or not the restart app button is enabled or not doesn't handle all cases and I'm leaning toward just leaving it enabled and warning the user when they click it.

Having said that, if you want to implement this I would more than likely take it though I'd prefer being able to install all add-ons without a restart.

Comment 4

[bugzilla_moz.20.ibyte]

As long as restarting is required, I'd prefer that the Restart Firefox button is always visible in the Add-on Manager. Now (FF2.0) you can't use the button to restart e.g. after switching to another already installed theme (which would be especially useful if you're not using session restore by default).

Comment 7

[Dave Townsend [:mossop]]

This is fixed with the new extension manager

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #7)
> This is fixed with the new extension manager

Nope, we still require a restart from the user. Tested with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; en-US; rv:2.0b2pre) Gecko/20100705 Minefield/4.0b2pre

Steps:
1. Install DOMi 2.0.5
2. Disable DOMi and restart Firefox
3. Check for updates

After step 3 the update has been applied and a restart is necessary.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Probably not doable with an automated test?

Comment 10

[Dave Townsend [:mossop]]

Totally testable, not going to block though.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This was fixed... sometime. Tested using steps in comment 8.