Options button not activable in new addons-theme window

RESOLVED INVALID

Status

Thunderbird
General
RESOLVED INVALID
12 years ago
7 years ago

People

(Reporter: Gerard Durand, Unassigned)

Tracking

({qawanted})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

13.10 KB, application/x-zip-compressed
Details
(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3

With thunderbird 1.5, while builing or updating a theme (in particular Noia2 theme for thunderbird), I'm able to activate the option button in the theme window by adding a #optionsButton {display: -moz-box !important;} in extensions.css file, and adding an optionURL line in the install.rdf file. This works quite well, and offer the possibility to add options in themes, and not only in extensions. But, with the new addons/extensions/theme design this does not work anymore. I have been just able to activate the option button with DOM inspector, but the command (an xul file given in the optionURL line of install.rdf) is not launched as it was with TB 1.5. I'm not sure it's a bug, but I think it's a regression between TB 2.0a and TB 1.5.

Reproducible: Always

Actual Results:  
OK with TB 1.5
Does not work with TB 2.0a1

Expected Results:  
add options to themes
(Reporter)

Comment 1

12 years ago
Created attachment 226001 [details]
Modified extension.js file

For Thunderbird 2.0 a1. May be also for Firefox 2 but not tested.
This is a modified java script file to correct this bug. Modified at line 938 to have an "Options" popup menu in themes and from line 1345 (case "cmd_options":) to add the possibility to have an activable "Options" button in themes.
With those correction it's now possible to activate Options in Themes when "optionsURL" is set in a theme's install.rdf.
Works now with noia2 theme and godlike theme.
(Reporter)

Comment 2

12 years ago
This "bug" can also be corrected in firefox 2.0b1 as it is almost the same extension.js file. I have tested it and it works !

Updated

10 years ago
Assignee: mscott → nobody
Reporter, does the issue still occur in the latest supported 2.0.0.x / Shredder trunk nightlies?

(1.5.0.x is now end-of-life and the latest supported 2.0.0.x is 2.0.0.16)
Whiteboard: closeme 2008-09-18
(Reporter)

Comment 4

10 years ago
Yes, nothing has changed since my first report. Following this thread, nobody has worked on this (or not found a correct solution). And I have not tested if the solutions I proposed is always applicable. Even, in TB 3.0b1, this problem is always the same. In fact, it's not really a bug, but a functionality which disappeared, and I think this is a regression. If you solve this, it could be nice.
Keywords: qawanted
Whiteboard: closeme 2008-09-18

Comment 5

7 years ago
Gerard, 
Is this still relevant for themes in version 3.3 (trunk)?  
Because even v3.1 now past accepting fixes for such things.
(Reporter)

Comment 6

7 years ago
I thought it was a bug or a regression. But now, it's so old, so it's certainly no more relevant. So, it's probably better to close it (but not solved !).

Gerard

Comment 7

7 years ago
Gerard, I don't quite understand. If it's not solved (problem still exists in version 3.1), then why do you say it's no longer relevant?  

Or, is the functionality no longer needed?
(Reporter)

Comment 8

7 years ago
This functionality is effectively no longer needed.
Before TB 3.0, it was possible yo use java script within a theme to configure some theme options. So, this particular activation possibility was missing in the cases related in previous posts. Now, it's practically forbidden for security reasons, and to obtain an option functionality in a them, you have to use an external extension. So, as I said, not solved for last 2.x versions, probably not useful for 3.x versions, so who cares now !

Gerard

Comment 9

7 years ago
Thanks Gerard. In that case, resolution = INVALID
Status: UNCONFIRMED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.