Closed
Bug 337942
Opened 18 years ago
Closed 18 years ago
Remove some unused interface functions in address book
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file, 1 obsolete file)
11.53 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
I've found the following interface functions that aren't used internally, and I can't see any real use externally either: nsIAbDirectory::addMailListWithKey nsIAddrDatabase::createMailListAndAddToDBWithKey These aren't actually used anywhere, and from what I can tell never have been. Additionally I think its wrong as it exposes a back-end database thing (the key) to the front-end, and in this case is mork specific. nsIAbDirectory::getValueForCard(in nsIAbCard card, in string name) nsIAbDirectory::setValueForCard(in nsIAbCard card, in string name, in wstring value) We have the nsIAbCard interface that will do this for us and the code that is there is mdb specific.
Assignee | ||
Comment 1•18 years ago
|
||
Simple patch to remove the unused functions as detailed in comment 0.
Attachment #221984 -
Flags: superreview?(dmose)
Attachment #221984 -
Flags: review?(dmose)
Assignee | ||
Comment 2•18 years ago
|
||
Note to self: nsIAddrDatabase::createNewCardAndAddToDBWithKey can also be removed.
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 221984 [details] [diff] [review] Remove unused functions I'm going to add the other function removal that I found to this patch before it gets reviewed...
Attachment #221984 -
Attachment is obsolete: true
Attachment #221984 -
Flags: superreview?(dmose)
Attachment #221984 -
Flags: review?(dmose)
Assignee | ||
Comment 4•18 years ago
|
||
Revised patch adding in the removal of the other redundant function I found.
Attachment #222051 -
Flags: superreview?(dmose)
Attachment #222051 -
Flags: review?(dmose)
Assignee | ||
Comment 5•18 years ago
|
||
Comment on attachment 222051 [details] [diff] [review] Remove unused functions v2 I'm guessing Dan is busy with calendar/lightning, so I'm switching reviews to David now he's back ;-)
Attachment #222051 -
Flags: superreview?(dmose)
Attachment #222051 -
Flags: superreview?(bienvenu)
Attachment #222051 -
Flags: review?(dmose)
Attachment #222051 -
Flags: review?(bienvenu)
Comment 6•18 years ago
|
||
Comment on attachment 222051 [details] [diff] [review] Remove unused functions v2 do we know that no extensions used get/set value for card? I guess they can use the card directly...
Attachment #222051 -
Flags: superreview?(bienvenu)
Attachment #222051 -
Flags: superreview+
Attachment #222051 -
Flags: review?(bienvenu)
Attachment #222051 -
Flags: review+
Assignee | ||
Comment 7•18 years ago
|
||
(In reply to comment #6) > (From update of attachment 222051 [details] [diff] [review] [edit]) > do we know that no extensions used get/set value for card? I guess they can use > the card directly... > I'm only putting this in for trunk onwards (not 1.8 branch) so extensions should have plenty of time to catch up. As they have the card to pass to the function, they should be able to just use the card straight off, I don't see any problems with that.
Assignee | ||
Comment 8•18 years ago
|
||
Patch checked in. That's all for now on this bug -> fixed.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•