337964 - changing account during message composing doesn't apply signing prefs from new account.

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Bartosz Piec]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3
Build Identifier: version 1.5.0.2 (20060308)

If you change an account during message composition (to the one with digital certificate assigned), you can send an email without giving the password. The Master Password dialog just not appearing. See details below.

Reproducible: Always

Steps to Reproduce:
1. Set an account with digital certificate and set a Master Password. Set another account without digital certificate.
2. Close Thunderbird.
3. Open Thunderbird.
4. In the Folders pane click an account without certificate.
5. Open a Compose window.
6. In the From: field change an account to the one with digital certificate.
7. Enter recipient, subject, body and send the e-mail.
Actual Results:  
The e-mail is sent but the Master Password dialog didn't appear.

Expected Results:  
The Master Password dialog should appear and the mail shouldn't be sent without giving the correct password.

Comment 1

[Bartosz Piec]

One more thing that I've noticed. The message is sent but it is not digitally signed...

Comment 2

[Daniel Veditz [:dveditz]]

The password wasn't requested because thunderbird didn't try to sign it. The real bug appears to be that changing the "From" account didn't successfully pick up all of the new account settings, specifically the "always sign messages" setting.

I haven't yet tried this specific case with a PKI certificate, but I do this all the time with Enigmail and PGP certs and always get my messages signed. In my case I use a second "identity" rather than a full "account" though.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Reporter, does the issue still occur in the latest supported 2.0.0.x / Shredder trunk nightlies?

(1.5.0.x is now end-of-life and the latest supported 2.0.0.x is 2.0.0.16)

Comment 4

[Bartosz Piec]

I cannot verify this now because I'm on holiday :) I'll check it at the begining of September.

Comment 5

[Bartosz Piec]

(In reply to comment #3)
> Reporter, does the issue still occur in the latest supported 2.0.0.x / Shredder
> trunk nightlies?

Yes, after changing to an account with message signing enabled, a massage was not signed.

Tested on Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1a2pre) Gecko/2008072908 Shredder/3.0a2pre.

Comment 6

[[:Aureliano Buendía]]

Reporter but also you use enigmail?

Comment 7

[Bartosz Piec]

No, I'm not using enigmail.

Comment 8

[Magnus Melin [:mkmelin]]

Confirmed on linux, latest nightly. (We're talking S/MIME)

Comment 9

[Magnus Melin [:mkmelin]]

Note to self. Should be around here:
http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#3213

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

I think this was in part intentional (as described in the code removal in this patch).

What the patch does is that it follows the identity prefs. 
If the encryption/signing pref was changed for a message, and the identity is changed after that, we try to keep what the user set. If there's no cert set up for the identity we change to however, we will uncheck signing/encryption.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 405675 [details] [diff] [review]
proposed fix

This seems reasonable though I admit that I've never really used this before and am not very aware of the use cases.

Comment 13

[Magnus Melin [:mkmelin]]

Comment on attachment 405675 [details] [diff] [review]
proposed fix

Should be lowish risk as it's quite contained to affecting how signing is applied when changing identity - and that's not working as expected now.

Comment 14

[Magnus Melin [:mkmelin]]

changeset:   4194:fbc2fe0f3fbf
http://hg.mozilla.org/comm-central/rev/fbc2fe0f3fbf

->FIXED