337992 - Fix outdated update prefs in sunbird.js

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

A bunch of our update prefs in sunbird.js are outdated.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - removes ancient update prefs and uses current ones from firefox.js - updates are disabled

Comment 2

[Joey Minta]

Comment on attachment 222031 [details] [diff] [review]
rev0 - removes ancient update prefs and uses current ones from firefox.js - updates are disabled

+// Blocklist preferences
+pref("extensions.blocklist.enabled", true);
+pref("extensions.blocklist.interval", 86400);
+pref("extensions.blocklist.url", "https://addons.mozilla.org/blocklist/1/%APP_ID%/%APP_VERSION%/");
+pref("extensions.blocklist.detailsURL", "http://www.mozilla.com/blocklist/");
We're handling this bit in another patch right?

+// Interval: When all registered timers should be checked (in milliseconds)
+//           default=5 seconds
+pref("app.update.timer", 600000);
Either the comment or the value is wrong here, if my math serves me.

+pref("extensions.update.interval", 86400);  // Check for updates to Extensions and 
+                                            // Themes every week
More math weirdness

+// AUM Set to:        Minor Releases:     Major Releases:
+// 0                  download no prompt  download no prompt
+// 1                  download no prompt  download no prompt if no incompatibilities
+// 2                  download no prompt  prompt
+//
+// See chart in nsUpdateService.js.in for more details
+//
+pref("app.update.mode", 1);
I'm tempted to say this should be 2 until we reach 1.0, but really, as discussed in IRC, we probably don't want any of these extra prefs until we actually have app-updating.

Comment 3

[Matthew (lilmatt) Willis]

Attachment: rev1 - removes app update crap. addresses nits, I think

Comment 4

[Joey Minta]

Comment on attachment 222123 [details] [diff] [review]
rev1 - removes app update crap. addresses nits, I think

nice, r=jminta here with some whitespace cleanup:

+pref("app.update.enabled", false);
+
+
+// Symmetric (can be overridden by individual extensions) update preferences.
probably don't need 2 lines there.

Comment 5

[Matthew (lilmatt) Willis]

Patch checked in (with nit) to trunk and MOZILLA_1_8_BRANCH