Bottom bevel of toolbar above content missing with no tabs

RESOLVED FIXED

Status

()

Firefox
Toolbars and Customization
--
minor
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Tuukka Tolvanen (sp3000), Assigned: James Ross)

Tracking

({regression})

Trunk
x86
Linux
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
Bottom bevel of toolbar above web page content missing with no browser tabs open. regression from bug 336847.
(Reporter)

Comment 1

12 years ago
Created attachment 222036 [details]
before/after

toolkit=cairo-gtk. gtk theme is clearlooks
(Assignee)

Comment 2

12 years ago
This is because Firefox is sharing winstripe files between OSes, which sucks. Time for crappy ifdefs.
(Assignee)

Updated

12 years ago
Assignee: nobody → silver
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

12 years ago
Created attachment 222046 [details] [diff] [review]
ifdef XP_WIN the code *sigh*

This also changes the way the line is removed to work around the Gecko bug 337859.
Attachment #222046 - Flags: review?(bugs)
(Assignee)

Comment 4

12 years ago
Comment on attachment 222046 [details] [diff] [review]
ifdef XP_WIN the code *sigh*

*sigh* This of course doesn't actually work, unlike the -1px margin which did...
Attachment #222046 - Attachment is obsolete: true
Attachment #222046 - Flags: review?(bugs)
(Assignee)

Comment 5

12 years ago
Created attachment 222168 [details] [diff] [review]
Override toolbar CSS only for XP_WIN

This patch plays nicely with the native theming (that's coming soon) and only applies to Windows. The moz-collapsed bit *is* a nasty evil hack, but then so is the entire of this bit of CSS.
Flags: blocking1.9a2?
(Assignee)

Updated

12 years ago
Attachment #222168 - Flags: review?(mconnor)
(Assignee)

Comment 6

12 years ago
Comment on attachment 222168 [details] [diff] [review]
Override toolbar CSS only for XP_WIN

This is blocking continued work on native themes. If I don't get something from this by 2006-06-19 I'm stopping this bloody game.

Updated

12 years ago
Attachment #222168 - Flags: review?(mconnor) → review+
(Assignee)

Comment 7

12 years ago
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Flags: blocking1.9a2?
You need to log in before you can comment on or make changes to this bug.