Closed Bug 338003 Opened 14 years ago Closed 14 years ago

imgCache::Init leaks imgCache if do_GetService fails

Categories

(Core :: ImageLib, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: ispiked)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, memory-leak)

Attachments

(1 file)

 
Attached patch patchSplinter Review
Attachment #222145 - Flags: review?
Attachment #222145 - Flags: review? → review?(pavlov)
Attachment #222145 - Flags: review?(pavlov) → review?(tor)
Attachment #222145 - Flags: review?(tor) → review?(pavlov)
Attachment #222145 - Flags: review?(pavlov) → review+
Whiteboard: [checkin needed]
Assignee: nobody → ispiked
Attachment #222145 - Flags: superreview+
What leak is this fixing?
Ah, the fact that the function relies on the observer service to raise the reference count above zero?  This doesn't seem like the best way to fix that...
Fixed on trunk. Bug 341686 is for the issues dbaron brought up.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.