Closed
Bug 338003
Opened 18 years ago
Closed 18 years ago
imgCache::Init leaks imgCache if do_GetService fails
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: ispiked)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file)
|
1.35 KB,
patch
|
pavlov
:
review+
pavlov
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #222145 -
Flags: review?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #222145 -
Flags: review? → review?(pavlov)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #222145 -
Flags: review?(pavlov) → review?(tor)
Attachment #222145 -
Flags: review?(tor) → review?(pavlov)
|
||
Updated•18 years ago
|
Attachment #222145 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [checkin needed]
|
||
Updated•18 years ago
|
Assignee: nobody → ispiked
|
|
||
Updated•18 years ago
|
Attachment #222145 -
Flags: superreview+
What leak is this fixing?
Ah, the fact that the function relies on the observer service to raise the reference count above zero? This doesn't seem like the best way to fix that...
|
|
Assignee | |
Comment 4•18 years ago
|
||
Fixed on trunk. Bug 341686 is for the issues dbaron brought up.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•