safe browsing slows down page load in non-enhanced mode

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
12 years ago
3 years ago

People

(Reporter: Tony Chang (Google), Assigned: Tony Chang (Google))

Tracking

({fixed1.8.1})

Trunk
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

12 years ago
We spend a considerable amount of time processing the url on page load.  We don't need to do that upfront, so we should defer until later.
(Assignee)

Comment 1

12 years ago
Created attachment 222091 [details] [diff] [review]
v1: defer local list check

Use a G_Alarm to defer the local list lookup until after docnavstart.

Also break a JS circular reference between MultiTableQuerier and the callback.

Start to refactor the code included in browser.xul to be namespaced in a single object.
Attachment #222091 - Flags: review?(brettw)
Attachment #222091 - Flags: approval-branch-1.8.1?
(Assignee)

Updated

12 years ago
Attachment #222091 - Flags: approval-branch-1.8.1? → approval-branch-1.8.1?(bryner)
(Assignee)

Comment 2

12 years ago
Created attachment 222116 [details] [diff] [review]
v2: defer local list check

Same as the last patch except we remove some abstraction layers (move webprogresslistener directly into phishing warden and get rid of EventRegistrar).
Attachment #222091 - Attachment is obsolete: true
Attachment #222116 - Flags: review?(brettw)
Attachment #222116 - Flags: approval-branch-1.8.1?(bryner)
Attachment #222091 - Flags: review?(brettw)
Attachment #222091 - Flags: approval-branch-1.8.1?(bryner)
Attachment #222116 - Flags: approval-branch-1.8.1?(bryner) → approval-branch-1.8.1+

Updated

12 years ago
Attachment #222116 - Flags: review?(brettw) → review+
(Assignee)

Comment 3

12 years ago
Created attachment 222131 [details] [diff] [review]
v3: defer local list check

tweak web progress listener to listen for only document requests rather than all requests

Comment 4

12 years ago
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.