Closed Bug 338064 Opened 17 years ago Closed 17 years ago

browser.formfill.enable = false, disables search suggest


(Firefox :: Search, defect)

2.0 Branch
Not set



Firefox 2 beta1


(Reporter: Peter6, Assigned: mozilla)



(Keywords: fixed1.8.1)


(1 file, 1 obsolete file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060515 Minefield/3.0a1 ID:2006051512 [cairo]

1. go to about:config and set browser.formfill.enable to false
2. type anything in the searchbar (use Yahoo or Google)

suggest is disabled
same problem on 1.8.1 branch of course
Version: Trunk → unspecified
"set browser.formfill.enable to false" is same as
tools>Options>Privacy "Saved Forms"
uncheck "Save information..."
As I said in, suggestion wasn't working here (with browser.formfill.enable = true). I changed <SuggestionURL>;qu=</SuggestionURL>
to <SuggestionURL><![CDATA[]]></SuggestionURL>
into google.xml (and made similar changes into yahoo.xml) and now it works.
I think it is fundamentally wrong that a user is forced to store his formfill data if he wishes to use suggest.
Flags: blocking1.9a1?
Flags: blocking-firefox2?
Assignee: nobody → joe
This seems to be the relevant code that's causing this:

This is because the search suggestions are implemented using the same autocomplete interface that the form history uses.
Blocks: 335435
+ for now until we decide what we're doing here.
Flags: blocking-firefox2? → blocking-firefox2+
*** Bug 340225 has been marked as a duplicate of this bug. ***
Target Milestone: --- → Firefox 2 beta1
Comment on attachment 225086 [details] [diff] [review]
Disables search history (but preserves suggestions) when form history is disabled

So I was a little bit confused as to why this fixes this bug, but I realized that it works because both nsFormHistory::AddEntry (called to save text in form history after it is entered) and nsFormHistory::AutoCompleteSearch (called to get autocomplete entries from form history when building the popup) already check formfill.enabled and behave accordingly. This means that you can also remove the attribute check at:

r=me with that.
Attachment #225086 - Flags: review?( → review+
Attachment #225086 - Attachment is obsolete: true
Attachment #225296 - Flags: approval-branch-1.8.1?(mconnor)
Attachment #225296 - Flags: approval-branch-1.8.1?(mconnor) → approval-branch-1.8.1+
Version: unspecified → 2.0 Branch
Landed on branch & trunk.
Closed: 17 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060615 Minefield/3.0a1 ID:2006061515

verified fixed on trunk
FYI, as a resource:
GSuggest extension
Flags: blocking1.9a1?
You need to log in before you can comment on or make changes to this bug.