338240 - FAYT for links matches two or more links at once

Status: NEW

(Toolkit :: Find Toolbar, defect, P3)

Description

[Daniel Wagner]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050926 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050926 Firefox/1.0.7

The find-as-you-type for links will match any text that starts in a link.  This can produce the confusing situation of matching two links at once: then, which should be focused?

Reproducible: Always

Steps to Reproduce:
1. Visit a website with links and text interspersed (in other words, pretty much any site).  These instructions will refer to the address above.
2. Hit ' to begin the find-links-as-you-type
3. Search for the text of the link and some of the text after the link.  On the sample page provided, try searching for "link with an" or so.

Actual Results:  
FAYT matches both the link and the text after the link.

Expected Results:  
FAYT matches up to the end of the link, then gives a "Phrase not found" beep.

Another possible way to see why this behaviour is confusing is to visit http://www.dragongoserver.net.  Searching for, i.e., "ms fa" (note the space) will match two links, one reading "Forums" and one reading "FAQ", that are on two different lines.

Comment 1

[Peter Kasting]

I'll take this.  I think I know how to fix the problem, it's just a question of when I can get to it.  (RangeStartsInsideLink() needs to change names and functions to check both ends of the range.)

Comment 2

[Asaf Romano (gone)]

Attachment: draft