338306 - aircanada.com - On trunk, "&nbsp" appears in menus due to UA-sniffing for "firefox"

Status: VERIFIED FIXED

Description

[Barry Marshall]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060516 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060516 Minefield/3.0a1

The nonbreakable space character code (&nbsp) is visible in the top row of the Air Canada site.  This is not visible with Firefox 1.5.0.3.

Reproducible: Always

Steps to Reproduce:
1.Start Firefox
2.Go to website
3.Observe results

Actual Results:  
& nbsp is visible.

Expected Results:  
& nbsp should not be visible.

Pictures to be attached.

Comment 1

[Barry Marshall]

Created attachment 222358 [details]
Page rendered with 1.5.0.3

Comment 2

[Barry Marshall]

Created attachment 222359 [details]
Page rendered with Trunk

Comment 3

[Régis Caspar]

From the page source: 
onmouseover="mouseOver(this,'cellOver')" class="menu"><a href="http://www.aircanada.com/en/offers/">Special&amp;nbspOffers</a></td><td dragover="true" 

So Firefox Trunk is not wrong here but 1.5.0.3 is.

 -> moving to Core/HTML:Parser

Comment 4

[Uri Bernstein (Google)]

The menu is built dynamically, using a function which does bad UA-sniffing (looks for "Firefox", which trunk builds no longer have in their UA string).

http://www.aircanada.com/shared/includes/common/nav_top/acoNavButtons.js :

function getButtonText(sometext){
 var agent = navigator.userAgent.toLowerCase(); 
 if(( agent.indexOf("netscape") != -1) || (agent.indexOf('firefox')!=-1)) {
 	if(sometext.match("&nbsp") == "&nbsp"){
		return sometext.replace("&nbsp"," ");
	}
 }
 return sometext;
}

So this is either Tech Evang or INVALID.

Comment 5

[Uri Bernstein (Google)]

(In reply to comment #4)
> (looks for "Firefox", which trunk builds no longer have in their UA string).

See bug 334756 for details on that, BTW.

Comment 6

[Uri Bernstein (Google)]

Sorry for all this bugspam.

Comment 7

[Michael Newton]

seems okay now

Comment 8

[Uri Bernstein (Google)]

(In reply to comment #7)
> seems okay now
> 

Indeed, someone commented out that sniffing function:

function getButtonText(sometext){
/* var agent = navigator.userAgent.toLowerCase(); 
 if(( agent.indexOf("netscape") != -1) || (agent.indexOf('firefox')!=-1)) {
 	if(sometext.match("&nbsp") == "&nbsp"){
		return sometext.replace("&nbsp"," ");
	}
 }*/
 return sometext;
}

Resolving WORKSFORME.

Comment 9

[Chris Lawson (gone)]

This was pretty clearly FIXED, as far as I can tell, by commenting out the sniffing. Fixing resolution and verifying.