338361 - Uninitialized in nsFormFillController::RemoveWindowListeners (toolkit/components/satchel/src/nsFormFillController.cpp)

Status: RESOLVED DUPLICATE of bug 340882

(Firefox :: Address Bar, defect)

Description

[Kenneth Herron]

This is coverity CID 325. Please see the sample URL. |chromeEventHandler| is used uninitialized at line 939 if the test at 936 fails.

This looks like an old aviary landing regression. See the line 858 section from <http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsFormFillController.cpp&branch=1.62&root=/cvsroot&subdir=mozilla/toolkit/components/satchel/src&command=DIFF_FRAMESET&rev1=1.38&rev2=1.39>.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Patch, with some whitespace changes and sanity checks.

Comment 2

[:Gijs (he/him)]

Just to be sure, are these review requests alright, or do I need somebody else for the r/sr/both?

Comment 3

[:Gijs (he/him)]

Comment on attachment 222777 [details] [diff] [review]
Patch

So, this is actually the wrong line number. My fault for using nano and where-is to find the place that needed tidying up. This place needs updating too, though. Do we have a bug for that already? If not, I'll do it in one go.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

*** This bug has been marked as a duplicate of 340882 ***