Closed Bug 338361 Opened 14 years ago Closed 14 years ago

Uninitialized in nsFormFillController::RemoveWindowListeners (toolkit/components/satchel/src/nsFormFillController.cpp)

Categories

(Firefox :: Address Bar, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED DUPLICATE of bug 340882

People

(Reporter: kherron+mozilla, Assigned: Gijs)

References

()

Details

(Keywords: coverity, crash)

Attachments

(1 obsolete file)

This is coverity CID 325. Please see the sample URL. |chromeEventHandler| is used uninitialized at line 939 if the test at 936 fails.

This looks like an old aviary landing regression. See the line 858 section from <http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsFormFillController.cpp&branch=1.62&root=/cvsroot&subdir=mozilla/toolkit/components/satchel/src&command=DIFF_FRAMESET&rev1=1.38&rev2=1.39>.
Whiteboard: [good first bug]
Attached patch Patch (obsolete) — Splinter Review
Patch, with some whitespace changes and sanity checks.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #222777 - Flags: superreview?(bryner)
Attachment #222777 - Flags: review?(bryner)
Just to be sure, are these review requests alright, or do I need somebody else for the r/sr/both?
Comment on attachment 222777 [details] [diff] [review]
Patch

So, this is actually the wrong line number. My fault for using nano and where-is to find the place that needed tidying up. This place needs updating too, though. Do we have a bug for that already? If not, I'll do it in one go.
Attachment #222777 - Attachment is obsolete: true
Attachment #222777 - Flags: superreview?(bryner)
Attachment #222777 - Flags: review?(bryner)

*** This bug has been marked as a duplicate of 340882 ***
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.