Please report any other irregularities here.
There are unittests in a function at the end of most of the source files. This adds extra size and extra code for the JS Interpreter to process even though we're not currently using it. At some point, we should add these back using existing testing conventions.
Can you wrap these in "#ifdef DEBUG" sections so that they will get stripped out in release builds?
Created attachment 222429 [details] [diff] [review] v1: remove unittests
Comment on attachment 222429 [details] [diff] [review] v1: remove unittests Oh, that would be smarter
Created attachment 222431 [details] [diff] [review] v2: #ifdef out unittests
Attachment #222431 - Flags: review?(darin)
Comment on attachment 222431 [details] [diff] [review] v2: #ifdef out unittests r=darin
Attachment #222431 - Flags: review?(darin) → review+
fixed on SAFEBROWSING_20060516_BRANCH
fixed on trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.