bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

remove unittests in source code (url-classifier)

RESOLVED FIXED

Status

()

Toolkit
Safe Browsing
RESOLVED FIXED
12 years ago
4 years ago

People

(Reporter: Tony Chang (Google), Assigned: Tony Chang (Google))

Tracking

({fixed1.8.1})

Trunk
x86
Linux
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
There are unittests in a function at the end of most of the source files.  This adds extra size and extra code for the JS Interpreter to process even though we're not currently using it.

At some point, we should add these back using existing testing conventions.
(Assignee)

Updated

12 years ago
Blocks: 337655

Comment 1

12 years ago
Can you wrap these in "#ifdef DEBUG" sections so that they will get stripped out in release builds?
(Assignee)

Comment 2

12 years ago
Created attachment 222429 [details] [diff] [review]
v1: remove unittests
Attachment #222429 - Flags: review?(darin)
(Assignee)

Comment 3

12 years ago
Comment on attachment 222429 [details] [diff] [review]
v1: remove unittests

Oh, that would be smarter
Attachment #222429 - Attachment is obsolete: true
Attachment #222429 - Flags: review?(darin)
(Assignee)

Comment 4

12 years ago
Created attachment 222431 [details] [diff] [review]
v2: #ifdef out unittests
Attachment #222431 - Flags: review?(darin)

Comment 5

12 years ago
Comment on attachment 222431 [details] [diff] [review]
v2: #ifdef out unittests

r=darin
Attachment #222431 - Flags: review?(darin) → review+

Comment 6

12 years ago
fixed on SAFEBROWSING_20060516_BRANCH
(Assignee)

Comment 7

12 years ago
fixed on trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.