338396 - breadcrumbs fetching wrong title

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Justin Wood (:Callek)]

On pages which do not have Title-override, (and never have) we are fetching the wrong output.

I found two of these pages so far, and fear this may be a much more widespread issue than just these two.

http://developer.mozilla.org/en/docs/CSS3_Columns
http://developer.mozilla.org/en/docs/Issues_Arising_From_Arbitrary-Element_hover

Comment 1

[Justin Wood (:Callek)]

http://developer.mozilla.org/en/docs/XForms:Form_Troubleshooting makes this issue even more nausiating. (XForms has the issue, while "XForms:Form_Troubleshooting" uses title-override and does not have the issue)

Comment 2

[Justin Wood (:Callek)]

Note, i do _not_ see this problem for the linked pages with developer-stage.

Comment 3

[Mike Shaver (:shaver emeritus)]

I don't see it on the CSS3 page, but I do on the XForms page, and yes, holy crap, that's bad.

Taking the bug, though I fear this is related to "live != stage" is some bad-smelling way.

Comment 4

[Mike Shaver (:shaver emeritus)]

Updating summary, since these pages don't seem to have <t-o> in them.

Comment 5

[Mike Shaver (:shaver emeritus)]

Logged in users see this, unless they're admins.  (I think; I'm the only admin around to check ATM.)

Comment 6

[Nickolay_Ponomarev]

FWIW, I see the issue on [[XForms]] too when logged in (even though I have sysop+bureuacrat flags on my account).

Comment 7

[A. Shimono [:himorin]]

(In reply to comment #6)
> FWIW, I see the issue on [[XForms]] too when logged in (even though I have
> sysop+bureuacrat flags on my account).

it's same with me.
and i've tried another account for inter-language bot. results are

not logged in : correct breadcrumbs
logged in with sysop+bureuacrat flags : incorrect breadcrumbs
logged in with bot flag : correct breadcrumbs

Comment 8

[Axel Hecht [:Pike]]

I see on http://developer.mozilla.org/en/docs/Extensions:Thunderbird, both logged in and not,

Main Page > NS_ENSURE_ARG_POINTER > Thunderbird

deCOMtaminate! ;-)

Comment 9

[Nickolay_Ponomarev]

So at least for me (logged in) this started occurring much more often recently.

ex: http://developer.mozilla.org/en/docs/DOM:document.createTextNode
Main Page > JS_GetProperty > JS_IdToValue > createTextNode 

Comment 10

[Eric Shepherd [:sheppy]]

Yes, this happens much more now.  We need to find someone to work on all the back-end stuff that needs doing, including getting the new breadcrumbs stuff finished.

Comment 12

[Nickolay_Ponomarev]

Can we maybe disable breadcrumbs for now, since they don't work anyway?

Comment 13

[A. Shimono [:himorin]]

Attachment: patch for t-o.php

first,, this patch will not resolve the problem.
but, i think t-o extension should check the existence of the DB entry before inserting the new value.
with current code, t-o entry for one document in the DB will increace on every commit from editors of MDC.

Comment 14

[Eric Shepherd [:sheppy]]

That patch is applied on developer-stage.

Comment 15

[A. Shimono [:himorin]]

(In reply to comment #14)
> That patch is applied on developer-stage.

ah,, forgot to comment about upgrading..
this patch DOES NOT delete already created t-o entries on DB.
so, it might be better to clear t-o table entries.

# i think this patch doesn't cause any problem with pre-created entries.
# b/c it updates all entries with the page id on db when target is committed.

Comment 16

[A. Shimono [:himorin]]

someone have DB access right:
i think the following SQL would not return 0 nor 1 but some larger value.
> select count(*) from title_override where to_id = <page_id>;
<page_id> sould be valid id got from like
> select * from title_override limit 1;

if it's true, it may cause the performance problem.
on my test server, t-o extension works when updating wiki page of cource, but viewing the page, too.
With current code, t-o extension inserts the t-o map entry on every called time, so the entries for one page will increase by page view..
And, in Breadcrumbs extension, it exec 'SELECT' without limiting return count.

Comment 18

[Eric Shepherd [:sheppy]]

Since we're now looking likely to be moving to Deki Wiki, I'm reprioritizing this.  I'd like to see us fix the current breadcrumbs to not be so badly broken as a temporary move until we get the move done.  We'll drop the new breadcrumb system we'd been working on.

Comment 19

[Mike Shaver (:shaver emeritus)]

I think the first step should probably be to just disable the title-override functionality from the breadcrumbs. That's probably enough to get us through to Deki-time, in fact, and we won't have to untangle whatever mess I've made of the database. :/

Comment 20

[Eric Shepherd [:sheppy]]

That's probably reasonable.

Comment 21

[A. Shimono [:himorin]]

how about to try clearing the current t-o table in DB before disabling the t-o functionality forever?
of cource, i know that the t-o has serious issue on its designing not to be able to delete the t-o entries when editor erased <t-o>.
but, it seems that the current problem like 'fetching wrong title' does not come from such issue for me..

Comment 22

[Fred Wenzel [:wenzel]]

Yes, looking at how many old title overrides are stored in the database, we should have this wiped first. Will file an IT bug to have this done, and if that won't remedy the situation, I also concur we should not do title-overrides for breadcrumbs anymore.

Comment 23

[Fred Wenzel [:wenzel]]

Is that an English-only bug? Otherwise I will run a DELETE FROM %locale%_title_override, for each %locale% we have.

Comment 24

[Fred Wenzel [:wenzel]]

As far as I can tell, emptying the tables has fixed this; please reopen if problems persist that I did not notice.

Thanks.

Comment 25

[Mike Shaver (:shaver emeritus)]

Reopening, the bogus breadcrumbs are back.  We should just disable the title-override code, as per comment 22.  Fred, can you do this? 

Comment 26

[Justin Wood (:Callek)]

Did the attachment here ever hit live MDC.

If not, can we please push it live and get the DB cleaned (again)?

Comment 27

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This continues to look awful; who is responsible for pushing whatever changes need to happen to production?  (and are they Cc'd on this bug?)

Comment 28

[Fred Wenzel [:wenzel]]

(In reply to comment #25)
> Reopening, the bogus breadcrumbs are back.  We should just disable the
> title-override code, as per comment 22.  Fred, can you do this? 

Argh, I missed this one. Sorry.

However, will apply the above patch and we can give it a shot. Should that not help, we will disable breadcrumbs.

Comment 29

[Fred Wenzel [:wenzel]]

I have to corrrect what I just said: We *did* apply the patch before and it did not help, which is why shaver asked me to disable the title overrides. I committed this to SVN r9941.

shaver, do we need to request a push to production?

Comment 30

[Mike Shaver (:shaver emeritus)]

(In reply to comment #29)
> I have to corrrect what I just said: We *did* apply the patch before and it did
> not help, which is why shaver asked me to disable the title overrides. I
> committed this to SVN r9941.
> 
> shaver, do we need to request a push to production?

Yes, please do!

Comment 31

[A. Shimono [:himorin]]

(In reply to comment #28)
> > Reopening, the bogus breadcrumbs are back.  We should just disable the
> > title-override code, as per comment 22.  Fred, can you do this? 
> 
> Argh, I missed this one. Sorry.
> 
> However, will apply the above patch and we can give it a shot. Should that not
> help, we will disable breadcrumbs.

as comment #13, that patch don't solve the problem discussed in this bug :-)
they *might* be deeply related problems (b/c that is the patch for breadcrumbs/t-o related and database related issue), but i cannot reproduce the problem as mdc real.
# yeah, of cource, i *wished* that the problem will be fixed with that patch :p

i doubt that this is related on the multiplexed DB installation or something. but it's not sure. To investigate this, i think we should know the status (data columns or etc) of the current t-o table.

Comment 32

[Eric Shepherd [:sheppy]]

Once the breadcrumbs are disabled, we'll just let this go.  No sense wasting more time on it since we're switching wiki engines in the next 2-3 months anyway.

Comment 33

[Fred Wenzel [:wenzel]]

The breadcrumbs are disabled now, so this is fixed.