338501 - Creating new folder from bookmark dialog causes blank, undismissable modal sheet

Status: RESOLVED DUPLICATE of bug 337646

(Firefox :: Bookmarks & History, defect)

Description

[Nick Fagerlund]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a2) Gecko/20060512 BonEcho/2.0a2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a2) Gecko/20060512 BonEcho/2.0a2

When a user bookmarks a page using some means other than drag-and-drop (i.e. the bookmarks menu, the Cmd-D keyboard shortcut, or the context menu from ctrl-clicking a link), she's given the option to create a new folder for it. When you try to use that feature in BonEcho alpha 2, you end up with a blank modal sheet that renders all Firefox UI except the application menu unresponsive. Plus some squirrelly bookmark-filing behavior--see "steps to reproduce" for all the gory details. 

Reproducible: Always

Steps to Reproduce:
This has some slightly tricksy behavior, depending on whether you make your choices with the keyboard or mouse:

1. Using the bookmarks menu, context menu, or Cmd-D, choose to bookmark the current page. [Modal sheet for creating bookmark rolls down.]
2. Click the down-arrow button to reveal more options for filing your bookmark. (You can resize the sheet, if you like.)
3. Click the "New folder..." button. [Bookmark sheet rolls up, much smaller sheet rolls down and requests a name and description for the new folder.]
--
4a. Either name the folder and type [return], or type [esc] to cancel the creation of a new folder. [New folder sheet rolls back up.]
--
4b. Either name the folder and click the OK button, or click the cancel button.  [New folder sheet rolls up, bookmark sheet rolls back down.]
5b. Place the bookmark wherever you want (in new folder, different folder, etc.). Click Ok, or click Cancel, or type [enter] or [esc].
Actual Results:  
RESULTS A: A blank sheet (which is the size of the create-bookmark sheet at the time it rolled up in step 3) appears (without having rolled down first), rolls up, and rolls back down again. It cannot be dismissed, though it can be resized. If you named the new folder, the folder has been created and your bookmark has been placed underneath it instead of inside it. If you cancelled creation of the new folder, it's been created anyway, but your bookmark hasn't been created. All window UI is unresponsive, though cursors and tooltips appear as appropriate. All menu options are greyed out except the application menu. You can call up the preferences window or the About window and you can quit the application; that's about it. Inconsistently (and less often than is the case in path B), Cmd-W may bring the whole app down. (Resizing the blank sheet once it appears will increase your chances of seeing this.)
--
RESULTS B: The bookmark sheet rolls up, indicating that it has finished its task, and a blank sheet rolls back down. It cannot be dismissed, though it can be resized. Your new folder and/or bookmark (or neither, if you cancelled both) have been created and placed appropriately. All window UI is unresponsive, though cursors and tooltips appear as appropriate. All menu options are greyed out except the application menu. You can call up the preferences window or the About window and you can quit the application; that's about it. Inconsistently (though much more often than in path A), Cmd-W may bring the whole app down. (Resizing the blank sheet once it appears will increase your chances of seeing this.)


Expected Results:  
Behavior identical to Firefox 1.5: No blank sheets, no unresponsive UI/menus, no crashing.

Comment 1

[jeff.fredrickson]

Reproduced on Mac OS X 10.4.6.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a2) Gecko/20060518 BonEcho/2.0a2 ID:2006051811

Comment 2

[Nick Fagerlund]

The squirmy part of this bug's behavior is gone on the patched Bon Echo test build Mark Mentovai posted in <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=337199#c25">comment 25</a> of bug 337199. Result A (the variation in behavior caused by hitting [enter] or [esc] in the new folder name/description sheet) no longer happens, and result B is exhibited regardless of what you do in the New Folder sheet. The divergent behavior must have been another regression caused by the big Mac event-handling patch that went in for a2.

Comment 3

[Nick Fagerlund]

Verifying on BonEcho alpha 3: bookmarking in new folder still burns my fields and steals my cattle. Reproduced this twice today, and the first one triggered a Talkback incident: 
ID# TB19189128H
The second time hung hard, failing to respond to cmd-Q and requiring me to kill the process from the terminal.
Also noticed some terminal chatter:
[e-mail]:(~)$ [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.remove]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: file:///Applications/BonEcho.app/Contents/MacOS/components/nsSessionStore.js :: sss_clearDisk :: line 1652"  data: no]pure virtual method called

Same chatter the second time around, minus that "pure virtual method called" at the end.

Adding keyword: crash and changing severity to critical. Justification: Loss of session data; catastrophic app failure. (Well, and potential misfiled bookmarks, but that's kind of petty in comparison.)

Comment 4

[Mark Mentovai]

*** This bug has been marked as a duplicate of 337646 ***

Comment 5

[timeless]

reporter: if the original problem didn't involve a crash, then the later problem is probably distinct. as it happens i'm currently chasing a pure virtual method induced crash.