Old url redirect does not handle vid's correctly

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
--
trivial
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Cameron, Assigned: Wladimir Palant (for Adblock Plus info Cc bugzilla@adblockplus.org))

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
Spawning this of the fix for Bug 332843. 
https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&id=628&vid=11803 doesn't redirect correctly, because "vid" matches ".*id"

Note that https://addons.mozilla.org/extensions/moreinfo.php?application=firefox&vid=11803&id=628 redirects fine, but while I'm not sure about how the old site constructed urls (if it put the vid or the id first), we should just fix this for the sake of goodness - if anyone had modified their urls or whatever, it would a pretty finicky bug.
Depends on: 337198
(Reporter)

Comment 1

11 years ago
Trev: seeing as bug 337198 was wontfixed, could you fix this separately please? 
Created attachment 236801 [details] [diff] [review]
Make sure only id is accepted as paramter name
Assignee: nobody → trev
Status: NEW → ASSIGNED
Attachment #236801 - Flags: first-review?(morgamic)
No longer depends on: 337198
Comment on attachment 236801 [details] [diff] [review]
Make sure only id is accepted as paramter name

Shaver, since you would be the one to approve this eventually, could you review this for Wladimir?
Attachment #236801 - Flags: first-review?(morgamic) → first-review?(shaver)
How should we test this?  htaccess changes scare me...

(Also: do we still need to concern ourselves with these old URL forms?  If they've been broken since May or earlier, I'm tempted to just leave it be!)

Updated

11 years ago
Attachment #236801 - Flags: first-review?(shaver) → review?(shaver)
Attachment #236801 - Flags: review?(shaver)
I forgot about that bug. Anyway, it is fixed in Remora.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.