33864 - Non-latin1 user name isn't display in Profile Manager

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Makoto Kato [:m_kato]]

REPRO STEP
==========
1. Run Profile Manager.
2. Click [Create Profile...]
3. Click [Next]
4. Input Japaese user name in [Enter New Profile name]
    ex) モジラ
4. Click [Choose Folder...] button
5. Select directory and click [OK]

RESULT
======
Incorrect directory name is displayed.

DESCRIPTION
===========
This problem is nsIFileSpec::appendRelativeUnixPath(in string relativePath). 

o chome/profile/content/default/newProfile1_2.js
  (mozilla/profile/resources/content/newProfile1_2.js)

function updateProfileName()
{
  var profileName = document.getElementById( "ProfileName" );
  var folderDisplayElement = document.getElementById( "ProfileDir" );
  var rootFolder = folderDisplayElement.getAttribute( "rootFolder" );
  try {
    var fileSpec = 
Components.classes["component://netscape/filespec"].createInstance();
    if ( fileSpec )
      fileSpec = fileSpec.QueryInterface( Components.interfaces.nsIFileSpec );
    if ( fileSpec )
      fileSpec.nativeUnicodePath = rootFolder;
    fileSpec.appendRelativeUnixPath( profileName.value );
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

o mozilla/xpcom/io/IFileSpec.idl

interface nsIFileSpec : nsISupports
{
	void appendRelativeUnixPath(in string relativePath);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The parameter of "appendRelativeUnixPath function" should be wstring.  But 
appendRelativeUnixPath is used in many components.  So I suggest to add 
following function in nsIFileSpec.

  void appendRelativeUnixUnicodePath(in wstring relativePath);

Comment 1

[Frank Tang]

I agree w/ m_kato's suggest. We should find someone to work closely on 
nsIFileSpec

Comment 2

[Frank Tang]

move to M16

Comment 3

[Frank Tang]

all the nsIFile and nsIFileSpec related issue should be look together. 

Comment 4

[Frank Tang]

I have move the code to use the nsILocalFile and fix it.

Comment 5

[Teruko Kobayashi]

I tested this in 2000042611 Win32 and 2000042609 Linux build.  I can create 
Japanese Profile name and the same Japanese Profile directory name is created.
I verified this in 200042710 Mac build.