33871 - [trk] (DOM2 HTML) HTMLDOMImplementation

Status: RESOLVED DUPLICATE of bug 592827

(Core :: DOM: Core & HTML, defect, P3)

Comment 1

[ekrock's old account (dead)]

Vidur, is this nsbeta2?

Comment 2

[Hixie (not reading bugmail)]

Taking QA Contact on all open or unverified DOM Style bugs...

Comment 3

[Hixie (not reading bugmail)]

Nominating this bug for nsbeta1 on behalf of [e-mail].

Comment 4

[Hixie (not reading bugmail)]

This bug got miscategorised as DOM Style instead of DOM HTML -- reassigning...

Comment 5

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 6

[Fabian Guisset]

Attachment: Proposed fix. Implement nsIDOMHTMLDOMImplementation

Note that this patch is NOT apply-able, it doesn't contain the makefile
changes. It also contains part of the patch to implement nsIDOMChromeWindow,
that part of the patch should be ignored! I included the new
nsIDOMHTMLDOMImplementation.idl file at the end of the diff so that it can be
reviewed, since it doesn't exist at the moment. Patch has been tested on linux.

Comment 7

[Fabian Guisset]

CC'ing sicking for review

Comment 8

[Fabian Guisset]

Oh yeah... the only known issue would be that HTMLDOMImplementation as a global
constructor is undefined. This is because DOMCI spit out an assertion when I did

DOM_CLASSINFO_MAP_BEGIN(DOMImplementation, nsIDOMHTMLDOMImplementation)

It complained about a name mismatch. So I had to leave the line as it was, i.e.

DOM_CLASSINFO_MAP_BEGIN(DOMImplementation, nsIDOMDOMImplementation)

I don't know if there's anything I can do about it.

Comment 9

[Fabian Guisset]

Attachment: This patch should be apply-able and only contains the relevant changes

Comment 10

[Fabian Guisset]

Don't bother reviewing the patch, it's not complete, as sicking pointed out.

Comment 11

[Fabian Guisset]

Attachment: Proposed fix v3 (implement HTMLDOMImplementation)

You can already review this if you want, but we'll have to wait for bug 30529
(nsIDOMChromeWindow changes) before checking this one in, otherwise there will
be conflicts, I think.
Note that the nsIDOMHTMLDOMImplementation.idl file is in the first attachment
of this bug.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 67922 [details] [diff] [review]
Proposed fix v3 (implement HTMLDOMImplementation)

+  // Set the title of the document, create a new <title> element

s/create/creating/

with that, r=sicking

Comment 13

[Fabian Guisset]

Assigning to myself now that I have my account. Woohoo!
Thanks for the review, sicking :-)

Comment 14

[Fabian Guisset]

per discussion with jst, marking future until this is actually useful.
Accepting.

Comment 15

[Alexey Chernyak]

ummmm we claim to support HTML DOM both Level 1 and 2.
is this a no longer valid bug?

Comment 16

[Boris Zbarsky [:bzbarsky]]

Alexey, this interface was removed from the HTML DOM spec at some point.

Comment 17

[Brett Zamir]

Shouldn't this be WONTFIX'd then? The DOM spec indeed no longer contains this: http://www.w3.org/TR/DOM-Level-2-HTML/html.html

Comment 18

[Brett Zamir]

Sorry, I mean it should be INVALID.