Safebrowsing: Each new window gives about 30 undefined properties in nsUrlClassifierLib.js

VERIFIED FIXED

Status

()

VERIFIED FIXED
12 years ago
4 years ago

People

(Reporter: u88484, Assigned: tony)

Tracking

({verified1.8.1})

Trunk
x86
Windows XP
verified1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

12 years ago
Warning: reference to undefined property fn.boundArgs_
Source file: file:///C:/Program%20Files/firefox/components/nsUrlClassifierLib.js
Line: 421
Warning: reference to undefined property fn.boundSelf_
Source file: file:///C:/Program%20Files/firefox/components/nsUrlClassifierLib.js
Line: 424
Warning: reference to undefined property fn.boundFn_
Source file: file:///C:/Program%20Files/firefox/components/nsUrlClassifierLib.js
Line: 428
and so on...

Comment 1

12 years ago
WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1 ID:2006052205 [cairo], no such warnings

Comment 2

12 years ago
Make sure you have set the prefs javascript.options.strict and javascript.options.showInConsole to true.

Comment 3

12 years ago
(In reply to comment #2)
> Make sure you have set the prefs javascript.options.strict and
> javascript.options.showInConsole to true.
OK those are strict warning and I had javascript.options.strict=false.

(Assignee)

Comment 4

12 years ago
Created attachment 222966 [details] [diff] [review]
v1: inline IsDef checks in bind

This gets rid of the warnings on new browser windows, which seems like a good idea because that's pretty noisy.

However, there are still some places in the code that uses the isDef function to check to see if something is defined and they will also trigger the warning.  I'm not sure if the function should be completely removed and inlined with (typeof foo != "undefined") everywhere.
Assignee: nobody → tony
Status: NEW → ASSIGNED
Tony, did you mean to ask for review on that patch, and maybe stop spewing in our consoles? ;)
(Assignee)

Comment 6

12 years ago
Created attachment 223738 [details] [diff] [review]
v2: remove ifDef everywhere

I had meant to go back and remove ifDef completely.  New patch should address that.
Attachment #222966 - Attachment is obsolete: true
Attachment #223738 - Flags: review?(darin)
Attachment #223738 - Flags: approval-branch-1.8.1?(darin)

Comment 7

12 years ago
Comment on attachment 223738 [details] [diff] [review]
v2: remove ifDef everywhere

ok, but why does this cause the warnings?
Attachment #223738 - Flags: review?(darin)
Attachment #223738 - Flags: review+
Attachment #223738 - Flags: approval-branch-1.8.1?(darin)
Attachment #223738 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 8

12 years ago
(In reply to comment #7)
> (From update of attachment 223738 [details] [diff] [review] [edit])
> ok, but why does this cause the warnings?

Passing undefined into a function triggers the warning.

Fixed on branch and trunk.

Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
(Reporter)

Updated

12 years ago
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1
Keywords: fixed1.8.1
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.