338817 - Safebrowsing: Each new window gives about 30 undefined properties in nsUrlClassifierLib.js

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[u88484]

Warning: reference to undefined property fn.boundArgs_
Source file: file:///C:/Program%20Files/firefox/components/nsUrlClassifierLib.js
Line: 421
Warning: reference to undefined property fn.boundSelf_
Source file: file:///C:/Program%20Files/firefox/components/nsUrlClassifierLib.js
Line: 424
Warning: reference to undefined property fn.boundFn_
Source file: file:///C:/Program%20Files/firefox/components/nsUrlClassifierLib.js
Line: 428
and so on...

Comment 1

[Régis Caspar]

WFM on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060522 Minefield/3.0a1 ID:2006052205 [cairo], no such warnings

Comment 2

[Simon Bünzli]

Make sure you have set the prefs javascript.options.strict and javascript.options.showInConsole to true.

Comment 3

[Régis Caspar]

(In reply to comment #2)
> Make sure you have set the prefs javascript.options.strict and
> javascript.options.showInConsole to true.
OK those are strict warning and I had javascript.options.strict=false.

Comment 4

[Tony Chang (Google)]

Attachment: v1: inline IsDef checks in bind

This gets rid of the warnings on new browser windows, which seems like a good idea because that's pretty noisy.

However, there are still some places in the code that uses the isDef function to check to see if something is defined and they will also trigger the warning.  I'm not sure if the function should be completely removed and inlined with (typeof foo != "undefined") everywhere.

Comment 5

[Phil Ringnalda (:philor)]

Tony, did you mean to ask for review on that patch, and maybe stop spewing in our consoles? ;)

Comment 6

[Tony Chang (Google)]

Attachment: v2: remove ifDef everywhere

I had meant to go back and remove ifDef completely.  New patch should address that.

Comment 7

[Darin Fisher]

Comment on attachment 223738 [details] [diff] [review]
v2: remove ifDef everywhere

ok, but why does this cause the warnings?

Comment 8

[Tony Chang (Google)]

(In reply to comment #7)
> (From update of attachment 223738 [details] [diff] [review] [edit])
> ok, but why does this cause the warnings?

Passing undefined into a function triggers the warning.

Fixed on branch and trunk.