338865 - Scriptable iface inheriting from noscript iface should throw error

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[jhp (no longer active)]

Currently, XPIDL prints a warning whenever a scriptable interface inherits from a non-scriptable interface.  These are the three that I have run into:

./imgIDecoderObserver.idl:96: Warning: imgIDecoderObserver is scriptable but
inherits from the non-scriptable interface imgIContainerObserver

./nsIScriptSecurityManager.idl:277: Warning: nsIScriptSecurityManager is
scriptable but inherits from the non-scriptable interface nsIXPCSecurityManager

./nsIWindowCreator2.idl:93: Warning: nsIWindowCreator2 is scriptable but
inherits from the non-scriptable interface nsIWindowCreator

Since a scriptable interface inheriting from a non-scriptable interface doesn't make much sense, bz suggested that this warning be turned into a hard error.

Comment 1

[jhp (no longer active)]

Attachment: patch

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 222908 [details] [diff] [review]
patch

Does this patch break anything in the current trunk?

Comment 3

[Boris Zbarsky [:bzbarsky]]

We shouldn't check it in until we fix the existing abuses, of course (and yes, there are some in current trunk).

Comment 4

[Mike Connor [:mconnor]]

WOuld like to get this, but we don't have traction and this isn't new, by any means.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 222908 [details] [diff] [review]
patch

This patch does not apply any more because the XPIDL compiler is now written in Python instead of C. ;)

Comment 6

[Andrew McCreight [:mccr8]]

With bug 1216885 fixed, making this a fatal error passes in a local build.

Comment 7

[Andrew McCreight [:mccr8]]

Attachment: Bug 338865 - Scriptable XPIDL iface inheriting from noscript iface should throw error.

Review commit: https://reviewboard.mozilla.org/r/178986/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178986/

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8907315 [details]
Bug 338865 - Scriptable XPIDL iface inheriting from noscript iface should throw error.

https://reviewboard.mozilla.org/r/178986/#review184384

Does this build successfully?  I recall seeing this error before somewhere around nsIDOMSelection, but perhaps we've cleaned up that code by now...

Comment 9

[Andrew McCreight [:mccr8]]

(In reply to Nathan Froyd [:froydnj] from comment #8)
> Comment on attachment 8907315 [details]
> Bug 338865 - Scriptable XPIDL iface inheriting from noscript iface should
> throw error.
> 
> https://reviewboard.mozilla.org/r/178986/#review184384
> 
> Does this build successfully?  I recall seeing this error before somewhere
> around nsIDOMSelection, but perhaps we've cleaned up that code by now...

nsIDOMSelection doesn't exist. There was a problem with nsISelectionPrivate, but I just fixed it in bug 1216885.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f636dde157b8
Scriptable XPIDL iface inheriting from noscript iface should throw error. r=froydnj

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f636dde157b8